Fix package types entry#339
Open
luuhongyii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typesentry to the declaration file generated and published by the build:dist/index.d.tsProblem
[email protected]publishesdist/index.d.ts, but its package manifest currently has:The package tarball does not include a root
index.d.ts, so tools that read the top-leveltypesfield can resolve to a missing file.Verification
npm pack [email protected] --dry-run --ignore-scripts --jsonshowsdist/index.d.tsis present and rootindex.d.tsis absentpnpm run buildsucceeds and generatesdist/index.d.tspnpm exec vitest runpasses: 10 testsnpm pack --dry-run --ignore-scripts --jsonafter build confirms the configuredtypesfile exists in the packed file listgit diff --checkNote
pnpm run typecheckcurrently fails on existing dependency/playground typing issues, including missing declarations from@rspack/core,webpack-sources,rolldown, and playground JSX settings. I left those unrelated issues out of this focused manifest fix.