fix: sync Controller value from _formValues on render to handle Activ…#13382
Open
ISHANTPATIL2005 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13381
Problem
When
Controlleris inside a React NativeActivity(or any tab layoutthat keeps components mounted but hidden), it shows a stale value when
the tab becomes visible again.
Steps to reproduce are in the issue with a CodeSandbox link:
https://codesandbox.io/p/sandbox/controller-activity-bug-6tpzdl
Why
useControllerusesuseWatchinternally. When a component is hiddeninside an
Activity, React skips state updates to that subtree. SouseWatchmisses the update and holds the old value.Fix
control._formValuesalways has the latest value regardless of React'srender cycle. On each render, if
_formValuesanduseWatchdisagree,we use
_formValuesinstead. No extra re-renders.Changes
src/useController.ts— sync value from_formValueson rendersrc/__tests__/useController.test.tsx— added regression testCode of Conduct