Skip to content

[receiver/mysql] Add the total count of buffer pool pages#41252

Merged
andrzej-stencel merged 3 commits into
open-telemetry:mainfrom
nenadnoveljic:mysql-total-buffer-pool-pages
Jul 24, 2025
Merged

[receiver/mysql] Add the total count of buffer pool pages#41252
andrzej-stencel merged 3 commits into
open-telemetry:mainfrom
nenadnoveljic:mysql-total-buffer-pool-pages

Conversation

@nenadnoveljic
Copy link
Copy Markdown
Member

@nenadnoveljic nenadnoveljic commented Jul 11, 2025

Description

Add the total count of buffer pool pages

@nenadnoveljic nenadnoveljic marked this pull request as ready for review July 11, 2025 13:07
@nenadnoveljic nenadnoveljic requested a review from a team as a code owner July 11, 2025 13:07
atoulme
atoulme reviewed Jul 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t total the sum of the other data points? Is it worth reporting directly? Can this not be derived from existing metrics?

@nenadnoveljic
Copy link
Copy Markdown
Member Author

nenadnoveljic commented Jul 14, 2025

Isn’t total the sum of the other data points? Can this not be derived from existing metrics?

it should be total = data + free + misc

Is it worth reporting directly?

total is more likely to be correct, while data, free or misc can be wrong by orders of magnitude, for example due to the bug 59550.

@github-actions github-actions Bot mentioned this pull request Jul 15, 2025
Closed
@nenadnoveljic
Copy link
Copy Markdown
Member Author

nenadnoveljic commented Jul 15, 2025

Isn’t total the sum of the other data points? Can this not be derived from existing metrics?

it should be total = data + free + misc

Is it worth reporting directly?

total is more likely to be correct, while data, free or misc can be wrong by orders of magnitude, for example due to the bug 59550.

@atoulme : total is correct—it divides total memory by page size. data counts items in the LRU list, which can include both compressed and uncompressed versions of the same page, so some pages might be double-counted. Are you okay with moving forward with this PR?

@atoulme
Copy link
Copy Markdown
Contributor

atoulme commented Jul 16, 2025

Sounds good! Just need a codeowner to weigh in

@antonblock
Copy link
Copy Markdown
Contributor

antonblock commented Jul 16, 2025

Makes sense, I'll take a look soon

ishleenk17
ishleenk17 reviewed Jul 23, 2025
View reviewed changes
Comment thread .chloggen/mysql-total-buffer-pool-pages.yaml Outdated
@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Jul 23, 2025

Minor nit. Change looks good.

@atoulme atoulme added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Jul 23, 2025
@andrzej-stencel andrzej-stencel merged commit ef04870 into open-telemetry:main Jul 24, 2025
192 of 195 checks passed
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib-old-fork Jul 29, 2025
@nenadnoveljic @atoulme
@ishleenk17 @povilasv
[receiver/mysql] Add the total count of buffer pool pages (#41252)
f120bc5 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add the total count of buffer pool pages

---------

Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Ishleen Kaur <[email protected]>
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
@nenadnoveljic @atoulme
@ishleenk17 @Dylan-M
[receiver/mysql] Add the total count of buffer pool pages (open-telem…
dab86c3 
…etry#41252)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add the total count of buffer pool pages

---------

Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Ishleen Kaur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atoulme atoulme atoulme left review comments

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@antonblock antonblock Awaiting requested review from antonblock

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

+1 more reviewer

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ArthurSens ArthurSens

Labels

ready to merge Code review completed; ready to merge by maintainers receiver/mysql

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nenadnoveljic @atoulme @antonblock @ishleenk17 @andrzej-stencel @ArthurSens