Skip to content

chore: normalize host URL in MultipartUploadHttpRequestManager#3452

Merged
ShreyasSinha merged 1 commit into
googleapis:mainfrom
louisnow:fix/multipart-upload-url-construction
Jan 15, 2026
Merged

chore: normalize host URL in MultipartUploadHttpRequestManager#3452
ShreyasSinha merged 1 commit into
googleapis:mainfrom
louisnow:fix/multipart-upload-url-construction

Conversation

@louisnow

@louisnow louisnow commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #3451

@louisnow louisnow requested a review from a team January 4, 2026 15:19
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Jan 4, 2026
@louisnow louisnow force-pushed the fix/multipart-upload-url-construction branch from 7511a25 to 5739574 Compare January 4, 2026 15:21
@Dhriti07 Dhriti07 self-requested a review January 6, 2026 05:07
@Dhriti07 Dhriti07 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2026

@Dhriti07 Dhriti07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the pr.
Can you please change the title from fix to chore and update the pr description.

@louisnow louisnow changed the title fix: normalize host URL in MultipartUploadHttpRequestManager chore: normalize host URL in MultipartUploadHttpRequestManager Jan 7, 2026
@louisnow louisnow force-pushed the fix/multipart-upload-url-construction branch from 5739574 to 66e6444 Compare January 7, 2026 09:31
@louisnow

louisnow commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

@Dhriti07 I've updated the PR title and description and changed the commit to also say chore:

@ShreyasSinha ShreyasSinha added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2026
@Dhriti07 Dhriti07 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2026
@ShreyasSinha

Copy link
Copy Markdown
Collaborator

/gcbrun

@ShreyasSinha ShreyasSinha merged commit fe52bca into googleapis:main Jan 15, 2026
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultipartUploadClient fails with custom host (missing path separator)

4 participants