Beta enum refactor#123
Open
herbertmilhomme wants to merge 3 commits into
Open
Conversation
Converts all Enums to INTs, and Removes the need for Sqlite DB to access data... ToDo: Finish transferring Sqlite DB to Static Enum ToDo: Go through project and remove old enum usage and replace with new implementation...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Enumeration classes instead of enum types
Doing something like that will convert every enum value into an int. Which means no need to convert and any value should can be used to check if valid or not. Which makes adding new pokemons easier to manage in the future
As well as maybe even easier for unity or online server-client relationships... but you miss out on drop-down feature and multiple choice (since any int value can be possible or accepted)
Maybe for pokemon enums the possibility for both a class and enum can exist side by side, instead of one or the other...
Status
Description
Testing
Concerns, notes, etc.
i think the rewrite is turning out for the better... after having recent talks with @MyzTyn because the data isnt being loaded dynamically by database, it might be easier on game ram/memory, and also address the whole sqlite issues we were dealing with in previous updates.
Related issues
Related PRs