Skip to content

Implement Core JetHinter#334

Merged
KyrylR merged 1 commit into
BlockstreamResearch:masterfrom
ivanlele:feature/core-jet-hinter
Jun 11, 2026
Merged

Implement Core JetHinter#334
KyrylR merged 1 commit into
BlockstreamResearch:masterfrom
ivanlele:feature/core-jet-hinter

Conversation

@ivanlele

@ivanlele ivanlele commented May 27, 2026

Copy link
Copy Markdown
Contributor

This PR introduces the CoreJetHinter implementation, demonstrating the changeability of the main executable jet set.

@ivanlele ivanlele requested a review from delta1 as a code owner May 27, 2026 10:39
@ivanlele

ivanlele commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@apoelstra After this PR, we can finally do the thing. We can load external implementations for Jet, JetHL, and JetHinter using dlopen2. I'll try to set up a minimal working example with it and a few jets.

apoelstra
apoelstra reviewed May 27, 2026
View reviewed changes
Comment thread src/jet/core.rs
@ivanlele

ivanlele commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@apoelstra After this PR, we can finally do the thing. We can load external implementations for Jet, JetHL, and JetHinter using dlopen2. I'll try to set up a minimal working example with it and a few jets.

I've created a draft PR for this branch that implements this feature.

I initially wanted to use dlopen2 to support multiple platforms, but it requires a Rust version higher than our MSRV. So, I wrote a small driver to do the same myself for that too:
ivanlele#10

@ivanlele

ivanlele commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@apoelstra After this PR, we can finally do the thing. We can load external implementations for Jet, JetHL, and JetHinter using dlopen2. I'll try to set up a minimal working example with it and a few jets.

I've created a draft PR for this branch that implements this feature.

I initially wanted to use dlopen2 to support multiple platforms, but it requires a Rust version higher than our MSRV. So, I wrote a small driver to do the same myself for that too: ivanlele#10

If we want this before Core jets support, I can rebase my draft on top of master. But having a jet directory would help to keep the project structure cleaner, as we can keep all jets related staff there

@ivanlele ivanlele mentioned this pull request Jun 2, 2026
Merged
KyrylR added a commit that referenced this pull request Jun 3, 2026
@KyrylR
Merge #344: Improve the source of types of jets
09602fb 
18845f8 Improve the source of types of jets (ivanlele)

Pull request description:

  This PR improves the source of truth for the underlying types consumed and produced by jets, following the suggestion in #334.

ACKs for top commit:
  apoelstra:
    ACK 18845f8; successfully ran local tests
  KyrylR:
    ACK 18845f8; successfully ran local tests

Tree-SHA512: f25da16d1e0544923ba43db7f70e50e84d0b41830081f3e1286673fa03341293433ca16c7f7cd614e91b02370a08f3c4b32af791403b3d659c7c898dffaa602a
@ivanlele ivanlele force-pushed the feature/core-jet-hinter branch from bf0a1d8 to 6fd9b88 Compare June 3, 2026 08:52
@ivanlele

ivanlele commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@apoelstra I rebased this one after #344 was merged.

stringhandler
stringhandler suggested changes Jun 4, 2026
View reviewed changes
Comment thread src/jet/core.rs
@ivanlele

ivanlele commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Do we need something else for this PR?

@ivanlele ivanlele force-pushed the feature/core-jet-hinter branch from 6fd9b88 to 7938728 Compare June 8, 2026 13:56
apoelstra
apoelstra approved these changes Jun 10, 2026
View reviewed changes

@apoelstra apoelstra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7938728; successfully ran local tests

KyrylR
KyrylR approved these changes Jun 11, 2026
View reviewed changes

@KyrylR KyrylR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7938728; successfully ran local tests

@KyrylR KyrylR merged commit 16fae19 into BlockstreamResearch:master Jun 11, 2026
11 checks passed
@KyrylR KyrylR mentioned this pull request Jun 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@KyrylR KyrylR KyrylR approved these changes

@delta1 delta1 Awaiting requested review from delta1 delta1 is a code owner

+1 more reviewer

@stringhandler stringhandler stringhandler requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivanlele @apoelstra @stringhandler @KyrylR