Skip to content

all: run golangci-lint fmt happy#308

Merged
dpasiukevich merged 2 commits into
google:mainfrom
zchee:goimports-local
Nov 19, 2025
Merged

all: run golangci-lint fmt happy#308
dpasiukevich merged 2 commits into
google:mainfrom
zchee:goimports-local

Conversation

@zchee
Copy link
Copy Markdown
Contributor

@zchee zchee commented Nov 18, 2025

Format import section

$ go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest fmt

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Nov 18, 2025

Summary of Changes

Hello @zchee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates gofumpt into the golangci-lint configuration, standardizing code formatting across the Go codebase. The changes primarily involve updating the .golangci.yml file with new formatter settings and applying these new formatting rules, particularly to import statements, across a wide range of Go source files. Additionally, it includes several minor code style refinements and corrections to ensure better consistency and readability.

Highlights

  • Code Formatting Enforcement: The golangci-lint configuration has been updated to include gofumpt as an enabled formatter, alongside goimports. This introduces stricter and more opinionated formatting rules for Go code.
  • Formatter Settings: Specific settings have been added for both goimports and gofumpt within the .golangci.yml file. goimports now uses google.golang.org/adk as a local prefix, and gofumpt is configured with extra-rules: true and a module-path.
  • Import Statement Reordering: Numerous Go files across the repository have had their import statements reordered and grouped to comply with the new gofumpt and goimports rules, ensuring consistent import block formatting.
  • Code Style and Readability Improvements: Minor code style adjustments were made, including grouping multiple var _ Interface = (*Struct)(nil) declarations into single var (...) blocks, simplifying function signatures (e.g., args map[string]any, result map[string]any to args, result map[string]any), and removing extraneous blank lines.
  • Octal Literal Correction: File permission octal literals used in os.WriteFile calls were updated from 0600 to 0o600 and 0666 to 0o666 for explicit octal representation.
  • Explicit Return Statements: Return statements in ExtractStateDeltas and extractStateDeltas functions were made explicit to improve clarity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces gofumpt for code formatting and applies its rules across the codebase. The changes primarily consist of import reordering, parameter grouping, and other stylistic improvements that enhance code consistency and readability. The configuration in .golangci.yml looks correct. Overall, this is a great step towards maintaining a consistent code style. I've added a few comments to highlight some of the beneficial changes.

Comment thread .golangci.yml
Comment thread agent/llmagent/llmagent.go
Comment thread artifact/gcsartifact/gcs_client.go
Comment thread cmd/adkgo/internal/deploy/cloudrun/cloudrun.go
Comment thread internal/sessionutils/utils.go
dpasiukevich
dpasiukevich reviewed Nov 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dpasiukevich dpasiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit and we can merge.

Thanks for the PR!

Comment thread agent/llmagent/llmagent_test.go Outdated
@zchee
Copy link
Copy Markdown
Contributor Author

zchee commented Nov 18, 2025

@dpasiukevich Fixed. PTAL.

@zchee zchee changed the title golangci-lint: add gofumpt formatters and settings all: run golangci-lint fmt happy Nov 18, 2025
dpasiukevich
dpasiukevich previously approved these changes Nov 18, 2025
View reviewed changes
zchee added 2 commits November 19, 2025 04:35
@zchee
golangci-lint: add gofumpt formatters and settings
e024368 
Signed-off-by: Koichi Shiraishi <[email protected]>
@zchee
all: run golangci-lint fmt happy
c6d8ffd 
$ go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest fmt

Signed-off-by: Koichi Shiraishi <[email protected]>
@zchee
Copy link
Copy Markdown
Contributor Author

zchee commented Nov 18, 2025 •
edited
Loading

@dpasiukevich Resolve conflict. PTALA.

dpasiukevich
dpasiukevich approved these changes Nov 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dpasiukevich dpasiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dpasiukevich dpasiukevich merged commit e0c09d1 into google:main Nov 19, 2025
3 checks passed
@zchee zchee deleted the goimports-local branch November 19, 2025 11:02
davidli2010 pushed a commit to davidli2010/adk-go that referenced this pull request Feb 4, 2026
@zchee
all: run golangci-lint fmt happy (google#308)
51e5724 
* golangci-lint: add gofumpt formatters and settings

Signed-off-by: Koichi Shiraishi <[email protected]>

* all: run golangci-lint fmt happy

$ go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest fmt

Signed-off-by: Koichi Shiraishi <[email protected]>

---------

Signed-off-by: Koichi Shiraishi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpasiukevich dpasiukevich dpasiukevich approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zchee @dpasiukevich