Do not empty config.php file if reading failed for any reason#33921
Merged
Conversation
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fix-config-file-emptied
branch
from
72ffa0a to
c2dafb0
Compare
Merged
Contributor
|
Seens like the tests work now? :) |
come-nc
added
3. to review
come-nc
requested review from
a team,
ArtificialOwl,
icewind1991,
skjnldsv and
szaimen
and removed request for
a team
Contributor
Author
Yes 😄 |
Contributor
|
/backport to stable24 |
Contributor
|
/backport to stable23 |
szaimen
approved these changes
Sep 8, 2022
Contributor
|
@come-nc can you please link the issues that get fixed by this? Thanks! :) |
Contributor
Author
|
Fixes #18620 |
Member
Contributor
Author
Merged
|
I've created that PR to demonstrate the atomic update approach. To be continued. |
|
The backport to stable23 failed. Please do this backport manually. |
Contributor
|
/backport to stable23 |
|
The backport to stable23 failed. Please do this backport manually. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18620
Signed-off-by: Côme Chilliet [email protected]