fix: update splitAndAssert to allow for more than two split parts#2103
fix: update splitAndAssert to allow for more than two split parts#2103ATGardner wants to merge 1 commit into
Conversation
|
It breaks unit tests. |
|
yeah, i was working on making a better fix, to have the unit tests pass + add a specific unit test to this case, but i understand github have fixed it on their side, so this pr can be closed. |
|
I've heard that they just rollback the recent changes. Maybe we should prepare for the future and make it future-proof. But first I would like to know exactly what was the reason for this change. Was it just an update of git server? There were other libraries that were affected. I wish someone could answer this. |
|
@ATGardner GitHub didn't exactly "fix the problem", they just reverted the change introduced on the Git server (not communicated, by the way), as you can see here The implementation suggested here should proceed because, at some point, these changes will likely be reverted by the GitHub team again. |
|
@manumbs do you know, by chance, what is the reason behind this change? Was it just up stream update of git server, or something done by GitHub? I really would like to know what was the reason behind this. If this is just how the new git server works, and it's not a breaking change for the canonical git client. We need to add this to isomorphic-git. Another thing is that if there are more than one element, there are new data send from the server. Maybe we need to use it somehow. Unfortunately, I lack knowledge of how the git protocol works. |
I'm fixing a bug or typo
npm run add-contributorand follow the prompts to add yourself to the READMEI'm adding a parameter to an existing command X:
src/api/X.js(andsrc/commands/X.jsif necessary)__tests__/test-X.jsif possiblenpm run add-contributorand follow the prompts to add yourself to the READMEI'm adding a new command:
src/api(andsrc/commandsif necessary)src/index.js__tests__/test-exports.jssrc/__tests__website/sidebars.jsonwebsite/versioned_sidebars/version-1.x-sidebars.jsonnpm run add-contributorand follow the prompts to add yourself to the READMEfixing the parsing of the capabilities request, due to a change in github.com response