Build safe static binaries for production use (avoid glibc getaddrinfo panic)

Qi Xiao · Qi Xiao · commit e40caf2fa8c2 · 2019-05-06T18:39:14.000+08:00
diff --git a/Makefile b/Makefile
@@ -33,10 +33,12 @@ status:
 
 
 builder: status
+	# alpine image libmusl is not compatible with golang race detector
+	# also alpine libmusl is required for building static binaries to avoid glibc getaddrinfo panic
 	docker build \
 		--tag $(BUILDER):$(VERSION) \
 		--tag $(BUILDER):latest \
-		--build-arg BUILD_ARG=use_all_cores \
+		--build-arg BUILD_ARG=release \
 		-f docker/builder.Dockerfile \
 		.
 
@@ -183,6 +185,11 @@ client: bin/cql bin/cql.test bin/cql-fuse bin/cql-mysql-adapter bin/cql-faucet
 
 all: bp miner client
 
+build-release: bin/cqld bin/cql-minerd bin/cql bin/cql-fuse bin/cql-mysql-adapter bin/cql-faucet
+
+release:
+	make -j$(JOBS) build-release
+
 clean:
 	rm -rf bin/cql*
 	rm -f *.cover.out
diff --git a/docker/Dockerfile b/docker/Dockerfile
@@ -1,5 +1,5 @@
 # Stage: all runner
-FROM frolvlad/alpine-glibc:latest
+FROM alpine:3.9
 
 ARG COMMIT
 ARG VERSION
diff --git a/docker/builder.Dockerfile b/docker/builder.Dockerfile
@@ -1,11 +1,11 @@
 # Stage: builder
-FROM golang:1.11-stretch as builder
+FROM golang:1.11-alpine3.9 as builder
 
 ARG BUILD_ARG
 
 WORKDIR /go/src/github.com/CovenantSQL/CovenantSQL
 COPY . .
+RUN apk --no-cache add build-base make git
 RUN make clean
 RUN GOOS=linux GOLDFLAGS="-linkmode external -extldflags -static" make ${BUILD_ARG}
-RUN rm -f bin/*.test
 
