fix(s3): prevent "0" path from being treated as root#58615
Merged
Conversation
joshtrichards
requested review from
CarlSchwan,
come-nc,
provokateurin and
sorbaugh
and removed request for
a team
joshtrichards
added
bug
3. to review
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
susnux
approved these changes
Feb 27, 2026
This was referenced Feb 27, 2026
Member
Author
|
Well, our side is fixed, but it turned up a similar problem in the AWS SDK: PR pending upstream: aws/aws-sdk-php#3253 This is the cause of the IMO shouldn't block this PR since we were already worse off before. I guess we may want to consider a temporary patch in our nextcloud/3rdparty repo since not sure (a) how long upstream will take (b) not sure how long until all of our supported majors are bumped to next SDK [Edit: or we drop the expanded test variations to return to the status quo on the test-side until upstream is fixed] |
Member
|
@joshtrichards sounds good, can you open a PR to add the patch to 3rdparty? |
provokateurin
approved these changes
Mar 2, 2026
CarlSchwan
approved these changes
Mar 2, 2026
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
susnux
force-pushed
the
jtr/fix-s3-normalizePath-falsy
branch
from
c12bbcf to
2d39c5a
Compare
Contributor
|
(rebased due to conflicts) |
This was referenced Mar 2, 2026
8 tasks
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevented folders from being created called
0(silently failed in the Web client; returning 405 on the backend)No more falsy ambiguity with
0named folder.Note: Only real changes are in line 69 and 133
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)