Skip to content

Also center vertically when cropping previews#18536

Merged
rullzer merged 1 commit into
masterfrom
enhancement/preview-center-vertically
Dec 23, 2019
Merged

Also center vertically when cropping previews#18536
rullzer merged 1 commit into
masterfrom
enhancement/preview-center-vertically

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Dec 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
Before After
Capture d’écran_2019-12-22_15-09-09 Capture d’écran_2019-12-22_15-09-19

@skjnldsv
Also center vertically when cropping previews
6df44e4 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Dec 22, 2019
@skjnldsv skjnldsv requested a review from rullzer December 22, 2019 14:08
rullzer
rullzer approved these changes Dec 23, 2019
View reviewed changes

@rullzer rullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

gary-kim
gary-kim approved these changes Dec 23, 2019
View reviewed changes

@gary-kim gary-kim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@rullzer rullzer merged commit 323fe46 into master Dec 23, 2019
@rullzer rullzer deleted the enhancement/preview-center-vertically branch December 23, 2019 07:36
@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Dec 23, 2019
@gary-kim

gary-kim commented Dec 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Wow, amazing speed!

@rullzer rullzer mentioned this pull request Dec 23, 2019
Merged
18 tasks
@skjnldsv skjnldsv mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: previews and thumbnails

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @gary-kim @rullzer