Handle sidebar mode separately to add the back button#3815
Open
lolamtisch wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the missing back button when MAL-Sync is opened via Firefox’s sidebar by introducing a dedicated sidebar panel HTML entrypoint and treating “sidebar” as a display mode where the back button should render.
Changes:
- Update the Firefox
sidebar_actionmanifest panel to load a newsidebar.htmlinstead ofwindow.html. - Add
src/_minimal/sidebar.htmland ensure it’s copied into the webextension dist output. - Render the nav back button in both
popupandsidebarmodes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webpackConfig/webextension.assets.js | Switches sidebar default panel to sidebar.html and copies the new file into dist/webextension/. |
| src/_minimal/sidebar.html | New minimal HTML entrypoint for the Firefox sidebar, setting mode="sidebar". |
| src/_minimal/components/nav/nav-back.vue | Extends back-button display logic to include sidebar mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Do you want to close the issue automatically ? I wondered if you forgot to write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3814