[MRG] Fix convolutional_barycenter2d kernel for non-symmetric images#132
Merged
rflamary merged 1 commit intoMar 13, 2020
Merged
Conversation
Collaborator
|
This is great, thank you for the PR. I think one day we should implement a proper convolution instead of those matrix products (or even circular convolution with Fourier as an option). you can add you name at the top of the file as Author . I will do the merge in the next days. I am still waiting for a few things but I will do a new release shortly. |
863238f to
d82e6eb
Compare
Contributor
Author
|
Agreed a proper convolution does sound useful in some circumstances. Interesting to note a simple usage of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your awesome package!
The code and examples for
ot.bregman.convolutional_barycenter2dassumes a symmetric image. This PR changes the kernel to allow for non-symmetric images and adds a simple test of this functionality.This addresses Issue #124