Skip to content

[mongodb] MongoError constructor accept string and object#43383

Merged
DanielRosenwasser merged 4 commits into
DefinitelyTyped:masterfrom
mathieug:patch-1
Mar 27, 2020
Merged

[mongodb] MongoError constructor accept string and object#43383
DanielRosenwasser merged 4 commits into
DefinitelyTyped:masterfrom
mathieug:patch-1

Conversation

@mathieug

@mathieug mathieug commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: http://mongodb.github.io/node-mongodb-native/3.5/api/MongoError.html
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@mathieug mathieug mentioned this pull request Mar 25, 2020
Merged
3 tasks
@typescript-bot typescript-bot added Where is Travis? Popular package This PR affects a popular package (as counted by NPM download counts). labels Mar 25, 2020
@typescript-bot

typescript-bot commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@mathieug Thank you for submitting this PR!

🔔 @CaselIT @alanmarcell @bitjson @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian @denys-bushulyak @bastienar @sindbach @geraldinelemeur @jishi @various89 @angela-1 @lirbank @hector7 @floric @erikc5000 @Manc @jloveridge @Ranguna @HosseinAgha @albertossilva @rauno56 @peterblazejewicz @LinusU - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

typescript-bot commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

@mathieug - It appears Travis did not correctly run on this PR! /cc @RyanCavanaugh to investigate and advise.

CaselIT
CaselIT suggested changes Mar 25, 2020
View reviewed changes
Comment thread types/mongodb/index.d.ts Outdated
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. The Travis CI build failed and removed Where is Travis? labels Mar 25, 2020
@typescript-bot

typescript-bot commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@mathieug The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@mathieug

mathieug commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

I'll let @RyanCavanaugh investigate and update this PR, thanks.

@peterblazejewicz

peterblazejewicz commented Mar 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I'll let ... investigate and update this PR, thanks.

@mathieug

There is something wrong with TS@next and existig defintions overriding/extending Promise like interface. See details of the CI, I've noted this in other failing CI. Hope I'll have an update on this shortly.

@peterblazejewicz

peterblazejewicz commented Mar 25, 2020

Copy link
Copy Markdown
Member

@mathieug it's just surfaced:
microsoft/TypeScript#37556

@peterblazejewicz

peterblazejewicz commented Mar 26, 2020

Copy link
Copy Markdown
Member

@mathieug
You should be able to run local npm test now to verify status and push update (or empty commit) to restart CI:
microsoft/TypeScript#37610

@mathieug

mathieug commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

Done :)

@typescript-bot

typescript-bot commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser

DanielRosenwasser commented Mar 27, 2020

Copy link
Copy Markdown
Member

Really this is just the same as string | object

@DanielRosenwasser DanielRosenwasser merged commit cc70df9 into DefinitelyTyped:master Mar 27, 2020
@typescript-bot

typescript-bot commented Mar 27, 2020

Copy link
Copy Markdown
Contributor

I just published @types/[email protected] to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaselIT CaselIT CaselIT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mathieug @typescript-bot @peterblazejewicz @DanielRosenwasser @CaselIT