Skip to content

fix: update attributes name in graphic material usage#470

Merged
ripel2 merged 1 commit into
mainfrom
update-graphic-usage
Feb 2, 2026
Merged

fix: update attributes name in graphic material usage#470
ripel2 merged 1 commit into
mainfrom
update-graphic-usage

Conversation

@Miou-zora

@Miou-zora Miou-zora commented Feb 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

To be able to compute the graphic material usage example, I updated the attribute value of some materials.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed incorrect texture name references in graphic material examples. Material texture configurations now properly reference the correct texture types.

@coderabbitai

coderabbitai Bot commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated texture name references in the graphic material usage example from ambient to diffuse in two material setup locations, correcting the texture designation used during material initialization.

Changes

Cohort / File(s) Summary
Texture Reference Correction
examples/graphic_material_usage/src/main.cpp		 Updated materialWithTexture and materialFromLocalTexture to use diffuseTexName instead of ambientTexName.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • ripel2

Poem

🐰 A texture was lost in the ambient haze,
But diffuse light shines through the glaze,
Two tiny tweaks, a rabbit's delight,
Material renders now pure and bright! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating texture attribute references (from ambientTexName to diffuseTexName) in material usage code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-graphic-usage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Feb 2, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ripel2 ripel2 requested a review from a team February 2, 2026 20:14
@ripel2 ripel2 merged commit 47c394e into main Feb 2, 2026
15 checks passed
@ripel2 ripel2 deleted the update-graphic-usage branch February 2, 2026 20:17
@coderabbitai coderabbitai Bot mentioned this pull request May 24, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ripel2 ripel2 ripel2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Miou-zora Miou-zora

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Miou-zora @ripel2