Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: EngineSquared/EngineSquared
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.3.2
Choose a base ref
...
head repository: EngineSquared/EngineSquared
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.3.3
Choose a head ref
  • 3 commits
  • 76 files changed
  • 5 contributors

Commits on May 22, 2026

  1. refactor(graphic): clarify context resource for graphics plugins (#596)

    # Pull Request
    
    ## Description
    I clarified Context by removing it and splitting it into each attribute
    to corresponding resources.
    
    ## Related Issues (Optional, put "None" if there are no related issues)
    Fixes #452 
    
    ## Type of Change
    
    - Code refactoring
    
    ## Changes Made
    List of the main changes in this PR:
    - Splitter Context class
    
    ## Testing (Optional, put "None" if you didn't have to test anything)
    <!-- Describe the tests you ran to verify your changes. Please delete
    options that are not relevant. -->
    - Unit tests pass (`xmake test`)
    - Code follows the project's style guidelines (`clang-format`)
    
    ### Test Environment
    - OS: macOS
    - Compiler: Clang
    
    ## Documentation
    <!-- Please delete options that are not relevant. -->
    
    - No documentation changes are required
    
    ## Checklist (Don't delete any options)
    - [x] My code follows the style guidelines of this project
    - [x] I have performed a self-review of my own code
    - [x] I have commented my code, particularly in hard-to-understand areas
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] New and existing unit tests pass locally with my changes
    - [x] Any dependent changes have been merged and published
    
    ## Time Spent (Optional, put "None" if you don't know)
    3~5 hours
    
    ## Screenshots/Videos (Optional, put "None" if it's not relevant)
    
    None
    
    ## Breaking Changes (Optional, Put "None" if there are no breaking
    changes)
    <!-- If this PR introduces breaking changes, describe them here and
    provide migration instructions. -->
    
    While using context, you should switch to the resource you want rather
    than using Context class.
    
    ## Additional Notes (Optional, Put "None" if there are no additional
    notes)
    <!-- Any additional information that reviewers should know. -->
    None
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Refactor**
    * Restructured rendering resource management to use granular resource
    types (DeviceContext, Queue, Adapter, Instance, Surface) instead of a
    combined Context abstraction, improving separation of concerns across
    graphics initialization, buffer management, and render pipeline systems.
    
    <!-- review_stack_entry_start -->
    
    [![Review Change
    Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/EngineSquared/EngineSquared/pull/596?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)
    
    <!-- review_stack_entry_end -->
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    Miou-zora authored May 22, 2026
    Configuration menu
    Copy the full SHA
    cd9c1fa View commit details
    Browse the repository at this point in the history

Commits on May 24, 2026

  1. feat: improve material and texture container api ergonomics avoid raw…

    … string keys allow per attribute setters (#597)
    
    # Pull Request
    
    ## Description
    I added a way to patch components to add an `on_update` mechanism. This
    allowed to update `Material` class when a texture is changed. I also
    added a way to add a string in key of `ResourceManager`
    
    ## Related Issues (Optional, put "None" if there are no related issues)
    Fixes #497 
    
    ## Type of Change
    <!-- Please delete options that are not relevant. -->
    
    - New feature (non-breaking change which adds functionality)
    
    ## Changes Made
    List of the main changes in this PR:
    - Add `UpdateComponent` in `Entity` and `EntityId`
    - Add `on_update` callback when a material is modified though
    `UpdateComponent`
    - Add a way to put string, string_view in methods of `ResourceManager`
    
    ## Testing (Optional, put "None" if you didn't have to test anything)
    <!-- Describe the tests you ran to verify your changes. Please delete
    options that are not relevant. -->
    - Unit tests pass (`xmake test`)
    - Code follows the project's style guidelines (`clang-format`)
    
    ### Test Environment
    - OS: macOS
    - Compiler: Clang
    
    ## Documentation
    <!-- Please delete options that are not relevant. -->
    
    - I have added/updated comments in the code
    
    ## Checklist (Don't delete any options)
    - [x] My code follows the style guidelines of this project
    - [x] I have performed a self-review of my own code
    - [x] I have commented my code, particularly in hard-to-understand areas
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [x] New and existing unit tests pass locally with my changes
    - [x] Any dependent changes have been merged and published
    
    ## Time Spent (Optional, put "None" if you don't know)
    <!-- Put here the time you were actively working on it like: 5 minutes,
    4 hours, some days, at least 1 month -->
    2 hours
    
    ## Screenshots/Videos (Optional, put "None" if it's not relevant)
    <!-- Add screenshots or videos to help explain your changes. -->
    None
    
    ## Breaking Changes (Optional, Put "None" if there are no breaking
    changes)
    <!-- If this PR introduces breaking changes, describe them here and
    provide migration instructions. -->
    None
    
    ## Additional Notes (Optional, Put "None" if there are no additional
    notes)
    <!-- Any additional information that reviewers should know. -->
    None
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **New Features**
    * Added component update mechanism enabling dynamic modifications to
    entity properties
    * Extended resource management system with string-based identifier
    support
    * Implemented automatic material synchronization between CPU and GPU
    components
    
    * **Tests**
    * Added comprehensive test coverage for string-based resource operations
    
    <!-- review_stack_entry_start -->
    
    [![Review Change
    Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/EngineSquared/EngineSquared/pull/597?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)
    
    <!-- review_stack_entry_end -->
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    Miou-zora authored May 24, 2026
    Configuration menu
    Copy the full SHA
    d84a2b0 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2026

  1. fix: make projet able to have a working xmake repo (#598)

    # Pull Request
    
    ## Description
    <!-- A clear and concise description of what this PR does and why it's
    needed. -->
    
    ## Related Issues (Optional, put "None" if there are no related issues)
    Fixes #(issue)
    Relates to #(issue)
    
    ## Type of Change
    <!-- Please delete options that are not relevant. -->
    
    - Bug fix (non-breaking change which fixes an issue)
    - New feature (non-breaking change which adds functionality)
    - Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
    - Documentation update
    - Performance improvement
    - Code refactoring
    - Build/CI configuration change
    - Project related stuff
    
    ## Changes Made
    List of the main changes in this PR:
    - Change 1
    - Change 2
    - Change 3
    
    ## Testing (Optional, put "None" if you didn't have to test anything)
    <!-- Describe the tests you ran to verify your changes. Please delete
    options that are not relevant. -->
    - Unit tests pass (`xmake test`)
    - Code follows the project's style guidelines (`clang-format`)
    - Manual testing performed (describe what you tested)
    
    ### Test Environment
    - OS: [e.g. Windows, Ubuntu, macOS]
    - Compiler: [e.g. MSVC, GCC, Clang]
    
    ## Documentation
    <!-- Please delete options that are not relevant. -->
    
    - I have updated the relevant documentation
    - I have added/updated comments in the code
    - No documentation changes are required
    
    ## Checklist (Don't delete any options)
    - [ ] My code follows the style guidelines of this project
    - [ ] I have performed a self-review of my own code
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] New and existing unit tests pass locally with my changes
    - [ ] Any dependent changes have been merged and published
    
    ## Time Spent (Optional, put "None" if you don't know)
    <!-- Put here the time you were actively working on it like: 5 minutes,
    4 hours, some days, at least 1 month -->
    
    ## Screenshots/Videos (Optional, put "None" if it's not relevant)
    <!-- Add screenshots or videos to help explain your changes. -->
    
    ## Breaking Changes (Optional, Put "None" if there are no breaking
    changes)
    <!-- If this PR introduces breaking changes, describe them here and
    provide migration instructions. -->
    
    ## Additional Notes (Optional, Put "None" if there are no additional
    notes)
    <!-- Any additional information that reviewers should know. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
    * Enhanced graphics surface configuration to gracefully handle scenarios
    where adapter resources are unavailable.
    
    * **Chores**
    * Refactored plugin build system header file discovery to use automatic
    directory scanning instead of fixed patterns, improving maintainability.
    
    <!-- review_stack_entry_start -->
    
    [![Review Change
    Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/EngineSquared/EngineSquared/pull/598?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)
    
    <!-- review_stack_entry_end -->
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: Uriah negbi <[email protected]>
    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    Co-authored-by: Copilot <[email protected]>
    Co-authored-by: Copilot <[email protected]>
    5 people authored May 25, 2026
    Configuration menu
    Copy the full SHA
    c7a6de6 View commit details
    Browse the repository at this point in the history
Loading