fix(BiMap): use value-based storage to eliminate rehash pointer invalidation#501
Merged
Miou-zora merged 3 commits intoMar 19, 2026
Conversation
7 tasks
…rage to prevent rehash invalidation Co-authored-by: Miou-zora <[email protected]>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on jolt bodyid mapping in physics plugin PR
fix(BiMap): use value-based storage to eliminate rehash pointer invalidation
Mar 18, 2026
…de-the-physics-plugin' into copilot/sub-pr-500
cbdbc85
into
496-feature-internalize-jolt-bodyid-entity-mapping-inside-the-physics-plugin
3 checks passed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



BiMapstored raw pointers to keys inside eachstd::unordered_mapas cross-references. Any insert or erase triggering a rehash invalidated those pointers, causing use-after-free bugs on lookup and removal.Changes
BiMap.hpp: Replace pointer-based cross-reference maps with two independent value-copying maps:std::unordered_map<TLeft, TRight> _leftToRightstd::unordered_map<TRight, TLeft> _rightToLeftAdd,Remove,Get, andContainsto work with stored values directly instead of dereferencing pointers.Before:
After:
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.