feat(physics): renamed PhysicsPlugin.hpp to follow consistent plugin naming convention by eliotttesnier · Pull Request #505 · EngineSquared/EngineSquared

eliotttesnier · 2026-03-23T12:59:10Z

Pull Request

Description

This pull request introduces the renaming of the old PhysicsPlugin class to PluginPhysics class.

Related Issues

Fixes #487
Relates to None

Type of Change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Performance improvement
Code refactoring
Build/CI configuration change

Changes Made

List the main changes in this PR:

Rename of the PhysicsPlugin class
Update of tests

Testing

Describe the tests you ran to verify your changes:

Unit tests pass (xmake test)
Code follows the project's style guidelines (clang-format)
Manual testing performed (describe what you tested) -> Launched unit tests

Test Environment

OS: Fedora 42
Compiler: gcc
Vulkan SDK Version: [e.g. 1.3.268.0]

Screenshots/Videos (if applicable)

Add screenshots or videos to help explain your changes.

Documentation

I have updated the relevant documentation
I have added/updated comments in the code
No documentation changes are required

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published

Breaking Changes

If this PR introduces breaking changes, describe them here and provide migration instructions.

Additional Notes

Any additional information that reviewers should know.

Summary by CodeRabbit

Chores
- Updated internal plugin header references and test suite naming conventions to align with refactored naming structure. No changes to functionality or test behavior.

coderabbitai · 2026-03-23T12:59:26Z

📝 Walkthrough

Walkthrough

This PR renames the physics plugin header from PhysicsPlugin.hpp to PluginPhysics.hpp to align with the naming convention used across other plugin headers. Include directives and GoogleTest suite identifiers were updated across the physics plugin implementation and all associated test files.

Changes

Cohort / File(s)	Summary
Physics Plugin Source `src/plugin/physics/src/Physics.hpp`, `src/plugin/physics/src/plugin/PluginPhysics.cpp`	Updated include directives from `plugin/PhysicsPlugin.hpp` to `plugin/PluginPhysics.hpp`.
Physics Plugin Tests `src/plugin/physics/tests/BodyEntityMapTest.cpp`, `src/plugin/physics/tests/BodyEntitySyncTest.cpp`, `src/plugin/physics/tests/PhysicsTest.cpp`, `src/plugin/physics/tests/VehicleCreationTest.cpp`, `src/plugin/physics/tests/VehicleForwardMovementTest.cpp`, `src/plugin/physics/tests/VehicleGravityDropTest.cpp`, `src/plugin/physics/tests/VehicleSteeringTest.cpp`, `src/plugin/physics/tests/VehicleWheelTransformSyncTest.cpp`	Updated include directives to reference `plugin/PluginPhysics.hpp` and renamed GoogleTest suite identifiers from `PhysicsPlugin` to `PluginPhysics`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

Divengerss

Poem

🐰 A rename so neat, so tidy and clean,
The physics header follows the plugin scene,
Convention restored with a simple refactoring sweep,
Consistency wins—hopping through code so deep! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	The PR successfully implements the requirements from issue `#487`: it renames PhysicsPlugin.hpp to PluginPhysics.hpp and updates all include references across implementation files and test files.
Out of Scope Changes check	✅ Passed	All changes are scoped to renaming the physics plugin header and updating includes; no unrelated code modifications, logic changes, or out-of-scope additions are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: renaming PhysicsPlugin.hpp to PluginPhysics.hpp to follow consistent plugin naming convention, which is the core objective of the entire changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2026-03-23T14:37:36Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…naming convention (#505) # Pull Request ## Description This pull request introduces the renaming of the old PhysicsPlugin class to PluginPhysics class. ## Related Issues Fixes #487 Relates to None ## Type of Change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Performance improvement - [x] Code refactoring - [ ] Build/CI configuration change ## Changes Made List the main changes in this PR: - Rename of the PhysicsPlugin class - Update of tests ## Testing Describe the tests you ran to verify your changes: - [x] Unit tests pass (`xmake test`) - [x] Code follows the project's style guidelines (`clang-format`) - [x] Manual testing performed (describe what you tested) -> Launched unit tests ### Test Environment - OS: Fedora 42 - Compiler: gcc - Vulkan SDK Version: [e.g. 1.3.268.0] ## Screenshots/Videos (if applicable) Add screenshots or videos to help explain your changes. ## Documentation - [ ] I have updated the relevant documentation - [ ] I have added/updated comments in the code - [x] No documentation changes are required ## Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published ## Breaking Changes If this PR introduces breaking changes, describe them here and provide migration instructions. ## Additional Notes Any additional information that reviewers should know.  ## Summary by CodeRabbit * **Chores** * Updated internal plugin header references and test suite naming conventions to align with refactored naming structure. No changes to functionality or test behavior.  --------- Co-authored-by: Miouzora <[email protected]>

eliotttesnier added 3 commits March 23, 2026 13:50

refactor(physics): renamed PhysicPlugin to PluginPhysics

ec965fb

refactor(physics): rename PhysicsPlugin to PluginPhysics

1cf16f2

refactor(physics): rename PhysicsPlugin to PluginPhysics in test files

81a7687

eliotttesnier changed the title ~~feat(physiccs): Renamed PhysicsPlugin.hpp to follow consistent plugin naming convention~~ feat(physics): renamed PhysicsPlugin.hpp to follow consistent plugin naming convention Mar 23, 2026

eliotttesnier and others added 2 commits March 23, 2026 14:56

Merge branch 'main' into main

9a0240c

Merge branch 'main' into main

9cd35a9

Miou-zora merged commit 8480426 into EngineSquared:main Mar 23, 2026
15 checks passed

coderabbitai Bot mentioned this pull request Mar 24, 2026

refactor(ci): remove git push step from clang-format job and update formatting logic #510

Merged

14 tasks

coderabbitai Bot mentioned this pull request Jun 10, 2026

feat: add xmake script for plugin creation and validation #615

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(physics): renamed PhysicsPlugin.hpp to follow consistent plugin naming convention#505

feat(physics): renamed PhysicsPlugin.hpp to follow consistent plugin naming convention#505
Miou-zora merged 5 commits into
EngineSquared:mainfrom
eliotttesnier:main

eliotttesnier commented Mar 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

sonarqubecloud Bot commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eliotttesnier commented Mar 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Description

Related Issues

Type of Change

Changes Made

Testing

Test Environment

Screenshots/Videos (if applicable)

Documentation

Checklist

Breaking Changes

Additional Notes

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

sonarqubecloud Bot commented Mar 23, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eliotttesnier commented Mar 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading