fix: add pull_request branch ignore rules to CI workflow#506
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughAdded a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 8-11: The pull_request.branches-ignore setting only filters PR
base branches and won't prevent runs for PRs whose source branches match
ga-ignore-**; update the workflow so each job checks the PR source branch
(github.head_ref) and skips when it matches the pattern (e.g., add an if
condition to each job or centralize this check in a reusable workflow), ensuring
jobs only run when github.head_ref does not match ga-ignore-**; reference the
pull_request.branches-ignore entry and add the per-job "if" guards (or a
reusable workflow input) to enforce source-branch ignores across all jobs.
|
# Pull Request ## Description I added ci run on pull request ## Related Issues None ## Type of Change Please delete options that are not relevant. - [x] Build/CI configuration change ## Changes Made List the main changes in this PR: - Added pull_request event triggering with branch excludes ## Testing None ### Test Environment - OS: macOS - Compiler: apple clang ## Documentation - [ ] I have updated the relevant documentation - [ ] I have added/updated comments in the code - [x] No documentation changes are required ## Checklist - [ ] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published ## Breaking Changes None ## Additional Notes None <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * CI workflow now also runs on pull request events, using the same branch filters as push triggers. * Simplified checkout steps by removing explicit reference parameters. * Removed an automatic "pull latest changes" step from the examples check job. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
# Pull Request ## Description I added ci run on pull request ## Related Issues None ## Type of Change Please delete options that are not relevant. - [x] Build/CI configuration change ## Changes Made List the main changes in this PR: - Added pull_request event triggering with branch excludes ## Testing None ### Test Environment - OS: macOS - Compiler: apple clang ## Documentation - [ ] I have updated the relevant documentation - [ ] I have added/updated comments in the code - [x] No documentation changes are required ## Checklist - [ ] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published ## Breaking Changes None ## Additional Notes None <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * CI workflow now also runs on pull request events, using the same branch filters as push triggers. * Simplified checkout steps by removing explicit reference parameters. * Removed an automatic "pull latest changes" step from the examples check job. <!-- end of auto-generated comment: release notes by coderabbit.ai -->



Pull Request
Description
I added ci run on pull request
Related Issues
None
Type of Change
Please delete options that are not relevant.
Changes Made
List the main changes in this PR:
Testing
None
Test Environment
Documentation
Checklist
Breaking Changes
None
Additional Notes
None
Summary by CodeRabbit