Skip to content

fix: add pull_request branch ignore rules to CI workflow#506

Merged
Miou-zora merged 3 commits into
mainfrom
run-ci-on-push
Mar 23, 2026
Merged

fix: add pull_request branch ignore rules to CI workflow#506
Miou-zora merged 3 commits into
mainfrom
run-ci-on-push

Conversation

@Miou-zora

@Miou-zora Miou-zora commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

I added ci run on pull request

Related Issues

None

Type of Change

Please delete options that are not relevant.

  • Build/CI configuration change

Changes Made

List the main changes in this PR:

  • Added pull_request event triggering with branch excludes

Testing

None

Test Environment

  • OS: macOS
  • Compiler: apple clang

Documentation

  • I have updated the relevant documentation
  • I have added/updated comments in the code
  • No documentation changes are required

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Breaking Changes

None

Additional Notes

None

Summary by CodeRabbit

  • Chores
    • CI workflow now also runs on pull request events, using the same branch filters as push triggers.
    • Simplified checkout steps by removing explicit reference parameters.
    • Removed an automatic "pull latest changes" step from the examples check job.

@Miou-zora Miou-zora self-assigned this Mar 23, 2026
@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Miou-zora has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b406a6a1-90f7-495c-982d-c773ce1ec130

📥 Commits

Reviewing files that changed from the base of the PR and between 250dc2c and c662c6c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
📝 Walkthrough

Walkthrough

Added a pull_request trigger to the CI workflow and removed explicit ref: ${{ github.ref_name }} parameters from several actions/checkout@v6 steps; also deleted the git pull origin ${{ github.ref_name }} "Pull latest changes" step in the check_examples job. Branch ignore patterns remain unchanged.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/ci.yml
Added pull_request trigger with existing branches-ignore (ga-ignore-**, gh-pages); removed explicit ref: ${{ github.ref_name }} from multiple actions/checkout@v6 steps; removed the "Pull latest changes" (git pull origin ${{ github.ref_name }}) step in check_examples job.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ci

Suggested reviewers

  • ripel2

Poem

🐇 I hopped through lines of YAML bright,

Pull requests now spark the light.
Checkouts trimmed, one pull took flight,
CI dances through the night. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding pull_request event triggering with branch ignore rules to the CI workflow, which aligns with the changeset's primary objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch run-ci-on-push

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 8-11: The pull_request.branches-ignore setting only filters PR
base branches and won't prevent runs for PRs whose source branches match
ga-ignore-**; update the workflow so each job checks the PR source branch
(github.head_ref) and skips when it matches the pattern (e.g., add an if
condition to each job or centralize this check in a reusable workflow), ensuring
jobs only run when github.head_ref does not match ga-ignore-**; reference the
pull_request.branches-ignore entry and add the per-job "if" guards (or a
reusable workflow input) to enforce source-branch ignores across all jobs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a0b95603-451b-4099-bcb6-8ee6f0b16001

📥 Commits

Reviewing files that changed from the base of the PR and between 57d1a26 and fe85a94.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Comment thread .github/workflows/ci.yml Outdated
@sonarqubecloud

Copy link
Copy Markdown

@Miou-zora Miou-zora merged commit 09a9ebe into main Mar 23, 2026
27 checks passed
@Miou-zora Miou-zora deleted the run-ci-on-push branch March 23, 2026 13:56
@coderabbitai coderabbitai Bot mentioned this pull request Mar 23, 2026
20 tasks
Miou-zora added a commit that referenced this pull request Mar 26, 2026
# Pull Request

## Description
I added ci run on pull request

## Related Issues

None

## Type of Change
Please delete options that are not relevant.

- [x] Build/CI configuration change

## Changes Made
List the main changes in this PR:
- Added pull_request event triggering with branch excludes

## Testing

None

### Test Environment
- OS: macOS
- Compiler: apple clang

## Documentation
- [ ] I have updated the relevant documentation
- [ ] I have added/updated comments in the code
- [x] No documentation changes are required

## Checklist
- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published

## Breaking Changes

None

## Additional Notes

None


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* CI workflow now also runs on pull request events, using the same
branch filters as push triggers.
  * Simplified checkout steps by removing explicit reference parameters.
* Removed an automatic "pull latest changes" step from the examples
check job.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Miou-zora added a commit that referenced this pull request Mar 27, 2026
# Pull Request

## Description
I added ci run on pull request

## Related Issues

None

## Type of Change
Please delete options that are not relevant.

- [x] Build/CI configuration change

## Changes Made
List the main changes in this PR:
- Added pull_request event triggering with branch excludes

## Testing

None

### Test Environment
- OS: macOS
- Compiler: apple clang

## Documentation
- [ ] I have updated the relevant documentation
- [ ] I have added/updated comments in the code
- [x] No documentation changes are required

## Checklist
- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published

## Breaking Changes

None

## Additional Notes

None


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* CI workflow now also runs on pull request events, using the same
branch filters as push triggers.
  * Simplified checkout steps by removing explicit reference parameters.
* Removed an automatic "pull latest changes" step from the examples
check job.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant