Skip to content

feat(check_leaks): make memory leak check mandatory to pass CI #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miou-zora merged 2 commits into from
Apr 9, 2026
Merged

feat(check_leaks): make memory leak check mandatory to pass CI #578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab11f0
feat(check_leaks): make memory leak check mandatory to pass CI
Miou-zora Apr 9, 2026
acd43e0
fix(check_leaks): raise error for missing executable instead of print…
Miou-zora Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tools/xmake/check_leaks.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ local function check_leaks_macos(targets, leaks_tool, project, os, verbose)
local bin_path = path.join(os.projectdir(), target:targetdir(), "debug", target:filename())

if not os.isfile(bin_path) then
print("Executable not found for target: " .. target_name)
goto continue
raise("Executable not found for target: " .. target_name)
end

print("Running leaks check on: " .. bin_path)
Expand All @@ -24,7 +23,6 @@ local function check_leaks_macos(targets, leaks_tool, project, os, verbose)
if return_value ~= 0 then
table.insert(failing_targets, target_name)
end
::continue::
end
return failing_targets
end
Expand Down Expand Up @@ -78,6 +76,7 @@ task("check_leaks")
for _, target in ipairs(failing_targets) do
print(" - " .. target)
end
raise("Memory leaks detected in " .. #failing_targets .. " target(s).")
else
print("No memory leaks found.")
end
Expand Down
Loading