Skip to content

refactor(plugin): mark Plugin classes as final#583

Merged
Miou-zora merged 4 commits into
mainfrom
582-bug-fix-final-destructor-compilation-warnings
Apr 11, 2026
Merged

refactor(plugin): mark Plugin classes as final#583
Miou-zora merged 4 commits into
mainfrom
582-bug-fix-final-destructor-compilation-warnings

Conversation

@Miou-zora

@Miou-zora Miou-zora commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Fix "final" warnings on macOS

Related Issues (Put "None" if there are no related issues)

close #582

Type of Change

Please delete options that are not relevant.

  • Code refactoring

Changes Made

List the main changes in this PR:

  • Added final keyword to plugin classes

Testing

Describe the tests you ran to verify your changes. Please delete options that are not relevant.

  • Unit tests pass (xmake test)

Test Environment

  • OS: macOS
  • Compiler: Clang

Screenshots/Videos (Put "None" if there are no related issues)

None

Documentation

Please delete options that are not relevant.

  • No documentation changes are required

Checklist (Don't delete any options)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Breaking Changes (Put "None" if there are no related issues)

None

Additional Notes (Put "None" if there are no related issues)

None

@Miou-zora Miou-zora self-assigned this Apr 11, 2026
@Miou-zora Miou-zora linked an issue Apr 11, 2026 that may be closed by this pull request
[BUG] Fix final destructor compilation warnings #582
Closed
@coderabbitai

coderabbitai Bot commented Apr 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Miou-zora has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1bd2305c-c1d5-469a-917d-503c2f556d6e

📥 Commits

Reviewing files that changed from the base of the PR and between 40f6448 and 544e2f4.

📒 Files selected for processing (6)
  • .github/workflows/deploy_doxygen_page.yml
  • src/engine/tests/engine/Scheduler.cpp
  • src/plugin/default-pipeline/src/plugin/PluginDefaultPipeline.hpp
  • src/plugin/event/src/plugin/PluginEvent.hpp
  • src/plugin/physics/src/plugin/PluginPhysics.hpp
  • tools/xmake/build_documentation.lua
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 582-bug-fix-final-destructor-compilation-warnings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 11, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Miou-zora Miou-zora merged commit d5a87e7 into main Apr 11, 2026
28 checks passed
@Miou-zora Miou-zora deleted the 582-bug-fix-final-destructor-compilation-warnings branch April 11, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Miou-zora Miou-zora

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Fix final destructor compilation warnings

1 participant

@Miou-zora