feat(graphic): update header file inclusions for improved structure by MasterLaplace · Pull Request #420 · EngineSquared/EngineSquared

MasterLaplace · 2026-01-10T16:03:31Z

I tried using xrepo, but these headers are missing from the xmake.lua file in the graphic plugin.

add_headerfiles("src/(component/*.hpp)")
add_headerfiles("src/(system/GPUComponentManagement/*.hpp)")
add_headerfiles("src/(system/preparation/*.hpp)")
add_headerfiles("src/(system/presentation/*.hpp)")
add_headerfiles("src/(utils/shader/*.hpp)")

Summary by CodeRabbit

Chores
- Reorganized header file inclusions and internal build configuration for the graphics plugin.
- Added several header patterns to improve component and shader coverage while retaining existing headers.
- No changes to runtime behavior, public APIs, or exported declarations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-10T16:03:41Z

📝 Walkthrough

Walkthrough

This change updates the PluginGraphic build script to remove a top-level exclude and expand header file globs, adding component, GPUComponentManagement, preparation, presentation, and shader utility header patterns. No build logic or public APIs were modified.

Changes

Cohort / File(s)	Summary
Build configuration `src/plugin/graphic/xmake.lua`	Removed top-level exclude (`excludes("../object/xmake.lua")`) and added header file patterns: `add_headerfiles("src/(component/.hpp)")`, `add_headerfiles("src/(system/GPUComponentManagement/.hpp)")`, `add_headerfiles("src/(system/preparation/.hpp)")`, `add_headerfiles("src/(system/presentation/.hpp)")`, `add_headerfiles("src/(utils/shader/.hpp)")`. Retained/reorganized existing header globs: `add_headerfiles("src/(exception/.hpp)")`, `add_headerfiles("src/(plugin/.hpp)")`, `add_headerfiles("src/(resource/.hpp)")`, `add_headerfiles("src/(resource/buffer/.hpp)")`, `add_headerfiles("src/(system/initialization/.hpp)")`, `add_headerfiles("src/(system/commandCreation/.hpp)")`, `add_headerfiles("src/(system/shutdown/.hpp)")`, `add_headerfiles("src/(utils/.hpp)")`, and `add_headerfiles("src/(.hpp)")`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I nibble through the header maze,
New paths for shaders, bright arrays,
GPU wings and components found,
Build files hum with quiet sound,
Hops of joy on code-made days.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately describes the main change: updating header file inclusions in the graphic plugin's xmake.lua configuration file for better project structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/plugin/graphic/xmake.lua (2)
3-5: Remove duplicate include statement.

The file ../object/xmake.lua is included twice (lines 3 and 5). Remove one of these duplicate includes to improve maintainability.
♻️ Proposed fix
 includes("../../utils/log/xmake.lua")
 includes("../object/xmake.lua")
 includes("../rendering-pipeline/xmake.lua")
-includes("../object/xmake.lua")
 includes("../window/xmake.lua")
30-33: Remove duplicate dependency declaration.

The dependency PluginObject is declared twice (lines 30 and 33). Remove one of these duplicate declarations.
♻️ Proposed fix
 add_deps("EngineSquaredCore")
 add_deps("PluginObject")
 add_deps("PluginRenderingPipeline")
 add_deps("PluginWindow")
-add_deps("PluginObject")
 add_deps("UtilsLog")

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 941a351 and 3882dd7.

📒 Files selected for processing (1)

src/plugin/graphic/xmake.lua

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

GitHub Check: Run tests (ubuntu-latest)
GitHub Check: Run tests (windows-latest)
GitHub Check: Run tests (macos-latest)
GitHub Check: Build and verify binaries (ubuntu-latest)
GitHub Check: Build and verify binaries (macos-latest)
GitHub Check: Build and verify binaries (windows-latest)

🔇 Additional comments (1)

src/plugin/graphic/xmake.lua (1)

38-50: All new header directories verified and exist with appropriate files.

The directory additions at lines 38-50 reference valid directories:

src/component/ — 4 header files

src/exception/ — 22 header files

src/system/GPUComponentManagement/ — 8 header files

src/system/preparation/ — 4 header files

src/system/presentation/ — 1 header file

src/utils/shader/ — 9 header files

The headerfile patterns are syntactically correct and follow the established convention. The changes properly expose these headers as part of the PluginGraphic target.

sonarqubecloud · 2026-01-10T16:15:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

MasterLaplace requested a review from Miou-zora January 10, 2026 16:03

MasterLaplace self-assigned this Jan 10, 2026

MasterLaplace added the bug Something isn't working label Jan 10, 2026

coderabbitai Bot reviewed Jan 10, 2026

View reviewed changes

Miou-zora approved these changes Jan 10, 2026

View reviewed changes

MasterLaplace added 2 commits January 10, 2026 17:15

feat(graphic): update header file inclusions for improved structure

cf6285e

feat(graphic): remove duplicate header file inclusion

59c7137

MasterLaplace force-pushed the update_xmake_graphic_headerfiles branch from bf45035 to 59c7137 Compare January 10, 2026 16:15

MasterLaplace merged commit 7b3f632 into main Jan 10, 2026
12 of 14 checks passed

MasterLaplace deleted the update_xmake_graphic_headerfiles branch January 10, 2026 16:39

coderabbitai Bot mentioned this pull request Jan 13, 2026

refactor(graphic): remove default render pipeline from graphic plugin #424

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(graphic): update header file inclusions for improved structure#420

feat(graphic): update header file inclusions for improved structure#420
MasterLaplace merged 2 commits into
mainfrom
update_xmake_graphic_headerfiles

MasterLaplace commented Jan 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 10, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

sonarqubecloud Bot commented Jan 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MasterLaplace commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jan 10, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MasterLaplace commented Jan 10, 2026 •

edited

Loading

coderabbitai Bot commented Jan 10, 2026 •

edited

Loading