give each multipledispatch-registered implementation a unique name#1496
give each multipledispatch-registered implementation a unique name#1496st-- wants to merge 7 commits into
Conversation
… that docs are generated correctly. resolves #1494
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1496 +/- ##
========================================
Coverage 95.08% 95.08%
========================================
Files 85 85
Lines 3782 3784 +2
========================================
+ Hits 3596 3598 +2
Misses 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdutor
left a comment
vdutor
left a comment
There was a problem hiding this comment.
Naming is unique but not really consistent across different multiple-dispatch methods. Can we follow one convention like, for example, _name__Type1__Type2?
|
|
||
| @conditional.register(object, InducingVariables, Kernel, object) | ||
| def _conditional( | ||
| def single_output_conditional( |
There was a problem hiding this comment.
| def single_output_conditional( | |
| def conditional__InducingVariables__Kernel( |
|
|
||
| @conditional.register(object, object, Kernel, object) | ||
| def _conditional( | ||
| def plain_conditional( |
There was a problem hiding this comment.
| def plain_conditional( | |
| def conditional__object__Kernel( |
| object, | ||
| ) | ||
| def _Kuf( | ||
| def _Kuf__Fallback__LinearCoregionalization( |
There was a problem hiding this comment.
Are you sure about the fallback here?
|
Names weren't consistent beforehand, either, and they're not really needed for anything specific. However, giving them unique names (note- names only need to be unique within a given python module) fixes the bug in our documentation, so can we please figure out something simple that makes it work as opposed to trying to find a perfect solution? I don't think it's worth the effort making everything fully consistent across the code-base. It's not practically feasible to encode all combinations. Sometimes we register the same implementation for different type pairs. |
|
@insysion, are you still planning to do this? |
insysion
left a comment
insysion
left a comment
There was a problem hiding this comment.
Leaving a comment to remove me from requested reviews
4 participants
so that docs are generated correctly. resolves #1494