Skip to content

Add more type hints.#1777

Merged
jesnie merged 1 commit into
developfrom
jesper/1386/mypy-covariances
Feb 14, 2022
Merged

Add more type hints.#1777
jesnie merged 1 commit into
developfrom
jesper/1386/mypy-covariances

Conversation

@jesnie
Copy link
Copy Markdown
Member

@jesnie jesnie commented Feb 10, 2022

  1. Reformat mypy.ini (again), so that code and corresponding tests are grouped together.
  2. Add type hints to covariances tests.
  3. Add type hints to experimental tests.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2022

Codecov Report

Merging #1777 (12dfbac) into develop (5f30be1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1777   +/-   ##
========================================
  Coverage    97.16%   97.16%           
========================================
  Files          100      100           
  Lines         4805     4805           
========================================
  Hits          4669     4669           
  Misses         136      136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f30be1...12dfbac. Read the comment docs.

@jesnie jesnie requested a review from uri-granta February 11, 2022 16:14
Copy link
Copy Markdown
Member

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread tests/gpflow/experimental/check_shapes/test_errors.py Outdated
@jesnie jesnie force-pushed the jesper/1386/mypy-covariances branch from 39ffea0 to 12dfbac Compare February 14, 2022 09:16
@jesnie jesnie merged commit c49d701 into develop Feb 14, 2022
@jesnie jesnie deleted the jesper/1386/mypy-covariances branch February 14, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants