Skip to content

Remove gpflow.experimental.check_shapes and import check_shapes instead.#2002

Merged
jesnie merged 1 commit into
developfrom
jesper/external_check_shapes
Oct 17, 2022
Merged

Remove gpflow.experimental.check_shapes and import check_shapes instead.#2002
jesnie merged 1 commit into
developfrom
jesper/external_check_shapes

Conversation

@jesnie
Copy link
Copy Markdown
Member

@jesnie jesnie commented Oct 17, 2022

No description provided.

@jesnie jesnie requested a review from sc336 October 17, 2022 10:06
@jesnie jesnie force-pushed the jesper/external_check_shapes branch from afa3ba3 to f2ad335 Compare October 17, 2022 10:24
Copy link
Copy Markdown
Contributor

@sc336 sc336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple and fine, happy to approve this if it passes automated testing.

@jesnie jesnie force-pushed the jesper/external_check_shapes branch from f2ad335 to 4207999 Compare October 17, 2022 10:41
@jesnie jesnie force-pushed the jesper/external_check_shapes branch from 4207999 to 5695b96 Compare October 17, 2022 11:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2022

Codecov Report

Base: 98.27% // Head: 98.09% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (5695b96) compared to base (6553277).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2002      +/-   ##
===========================================
- Coverage    98.27%   98.09%   -0.18%     
===========================================
  Files          108       93      -15     
  Lines         6549     5261    -1288     
===========================================
- Hits          6436     5161    -1275     
+ Misses         113      100      -13     
Impacted Files Coverage Δ
gpflow/conditionals/conditionals.py 100.00% <100.00%> (ø)
gpflow/conditionals/multioutput/conditionals.py 100.00% <100.00%> (ø)
...ow/conditionals/multioutput/sample_conditionals.py 100.00% <100.00%> (ø)
gpflow/conditionals/sample_conditionals.py 95.23% <100.00%> (ø)
gpflow/conditionals/uncertain_conditionals.py 100.00% <100.00%> (ø)
gpflow/conditionals/util.py 100.00% <100.00%> (ø)
gpflow/covariances/kufs.py 100.00% <100.00%> (ø)
gpflow/covariances/kuus.py 100.00% <100.00%> (ø)
gpflow/covariances/multioutput/kufs.py 100.00% <100.00%> (ø)
gpflow/covariances/multioutput/kuus.py 100.00% <100.00%> (ø)
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jesnie jesnie merged commit 42bd312 into develop Oct 17, 2022
@jesnie jesnie deleted the jesper/external_check_shapes branch October 17, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants