Skip to content

Sc336/2.7.0 master merge#2041

Merged
sc336 merged 17 commits into
masterfrom
sc336/2.7.0-master-merge-again
Jan 25, 2023
Merged

Sc336/2.7.0 master merge#2041
sc336 merged 17 commits into
masterfrom
sc336/2.7.0-master-merge-again

Conversation

@sc336
Copy link
Copy Markdown
Contributor

@sc336 sc336 commented Jan 24, 2023

After some frustration trying to merge develop into master while both are protected, this merges in a new branch (sc336/2.7.0-master-merge-again) which is created from develop and has master merged into it.

jesnie and others added 17 commits October 17, 2022 11:33
* Various docstring improvements

* Added and improved some comments

* Formatting changes

* Added myself as new contributor

* Edits made based on review from st--
* Updated to ignore mypy's new type-abstract error

* Looks like mypy won't quit on this one.

* More type hinting

* Sort

* Another try

* Another try

* Another try

* Go away mypy

* format

* More mypy wards

* Is this error connected?

* Removed unnecessary dummy package

* Another mypy error

* Format
…me#932) doesn't look like it's getting fixed any time soon, pinning to earlier version (#2014)
* Avoid loss of precision in to_default_float when input is a python float (#2021)

* avoid loss of precision in to_default_float

* add tests

* release management

* Updated to compensate for new mypy version (#2016)

* Updated to ignore mypy's new type-abstract error

* Looks like mypy won't quit on this one.

* More type hinting

* Sort

* Another try

* Another try

* Another try

* Go away mypy

* format

* More mypy wards

* Is this error connected?

* Removed unnecessary dummy package

* Another mypy error

* Format

* Fix mypy error. (#2009)

Co-authored-by: sc336 <[email protected]>
Co-authored-by: Jesper Nielsen <[email protected]>

* Some corrections to RELEASE.md (#2022)

* Update VERSION

* Update version

Co-authored-by: John Mcleod <[email protected]>
Co-authored-by: Jesper Nielsen <[email protected]>
Co-authored-by: Chris Morter <[email protected]>
* Add usage of monitoring with Adam to notebook

* Add self to contributors

* Update release notes

* Update doc/sphinx/notebooks/getting_started/monitoring.pct.py

Co-authored-by: st-- <[email protected]>

* Run make format

Co-authored-by: st-- <[email protected]>
* Rotated deploy key due to CircleCI security incident 2023-01-04

* Used the correct key this time

* Touched to force rerunning tests
… (#2033)

* Rotated deploy key due to CircleCI security incident 2023-01-04

Updated config with new key
* Release update
Squash merge master into develop.

Co-authored-by: sc336 <[email protected]>
Co-authored-by: Jesper Nielsen <[email protected]>
Co-authored-by: John Mcleod <[email protected]>
Co-authored-by: Jesper Nielsen <[email protected]>
Co-authored-by: Chris Morter <[email protected]>
* Merge master into develop (via sc336/2.7.0-merge)

Co-authored-by: sc336 <[email protected]>
Co-authored-by: John Mcleod <[email protected]>
Co-authored-by: Jesper Nielsen <[email protected]>
Co-authored-by: Chris Morter <[email protected]>
@sc336 sc336 requested a review from uri-granta January 24, 2023 15:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2023

Codecov Report

Base: 98.27% // Head: 98.01% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (2f6a628) compared to base (a568fed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2041      +/-   ##
==========================================
- Coverage   98.27%   98.01%   -0.26%     
==========================================
  Files         108       96      -12     
  Lines        6551     5401    -1150     
==========================================
- Hits         6438     5294    -1144     
+ Misses        113      107       -6     
Impacted Files Coverage Δ
gpflow/kernels/__init__.py 100.00% <ø> (ø)
gpflow/monitor/tensorboard.py 93.90% <ø> (ø)
gpflow/base.py 94.57% <100.00%> (ø)
gpflow/conditionals/conditionals.py 100.00% <100.00%> (ø)
gpflow/conditionals/multioutput/conditionals.py 100.00% <100.00%> (ø)
...ow/conditionals/multioutput/sample_conditionals.py 100.00% <100.00%> (ø)
gpflow/conditionals/sample_conditionals.py 95.23% <100.00%> (ø)
gpflow/conditionals/uncertain_conditionals.py 100.00% <100.00%> (ø)
gpflow/conditionals/util.py 100.00% <100.00%> (ø)
gpflow/covariances/kufs.py 100.00% <100.00%> (ø)
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st--
Copy link
Copy Markdown
Member

st-- commented Jan 24, 2023

I think the issue might have happened by squash-merging develop into master in a previous release. Or something like that. I remember squashing/rebasing commits on one of the branches during a merge was the issue...

@sc336 sc336 merged commit e794a89 into master Jan 25, 2023
@sc336 sc336 mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants