[MRG] Fix bug in gromov_wasserstein and gromov_wasserstein2#108
Merged
Conversation
rflamary
changed the title
kilianFatras
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am sending a new PR to solve a 'log' bug in the gromov_wasserstein2 function. Indeed, because of a variable name mismatch, the log was overwritten and was always returned.
In this PR, you will find:
Bug 'log' correction
Test log=False for gromov_wasserstein2
Removing 'H entropy' from doc for gromov_wasserstein and gromov_wasserstein2
numItermax bug for emd function inside cg function. The number of iter was fixed to 100.000 and could not be modified.
Test numItermaxEmd > 100000 for cg.