Skip to content

Autodocs: call all SwaggerClient constructors#416

Merged
Bento007 merged 1 commit into
masterfrom
akislyuk-autodocs-call-all-constructors
Aug 5, 2019
Merged

Autodocs: call all SwaggerClient constructors#416
Bento007 merged 1 commit into
masterfrom
akislyuk-autodocs-call-all-constructors

Conversation

@kislyuk

@kislyuk kislyuk commented Aug 5, 2019

Copy link
Copy Markdown
Member

No description provided.

@kislyuk kislyuk requested a review from Bento007 August 5, 2019 16:55
Bento007
Bento007 reviewed Aug 5, 2019
View reviewed changes

@Bento007 Bento007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bento007 Bento007 merged commit aed57a4 into master Aug 5, 2019
@Bento007 Bento007 deleted the akislyuk-autodocs-call-all-constructors branch August 5, 2019 23:38
@Bento007

Bento007 commented Aug 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

The failing test was unrelated to code addition.

======================================================================
FAIL: test_test_s3_agent_setup_for_file_upload__for_multiple_files__computes_stats_correctly (test.integration.upload.test_upload_area.TestUploadAreaFileUpload)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "<string>", line 3, in wrapper
  File "/home/travis/build/HumanCellAtlas/dcp-cli/test/integration/upload/test_upload_area.py", line 243, in test_test_s3_agent_setup_for_file_upload__for_multiple_files__computes_stats_correctly
    self.assertEqual(self.area.s3agent.file_upload_completed_count, 2)
AssertionError: 1 != 2
----------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bento007 Bento007 Bento007 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kislyuk @Bento007