Add async fixture support (#41)#45
Merged
Tinche merged 3 commits intoMar 24, 2017
Merged
Conversation
* Added async generator fixture support * Added async fixture support
Member
|
Honestly this looks like great work! Could you please add a little documentation to the readme? |
Contributor
Author
|
@Tinche yes I'll add documentation for these async fixtures this week. What about async fixtures |
Added docs for async fixtures
Member
|
Regarding function-scope only fixtures, I'll take what I can get. :) |
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some problems I didnt solved yet:
@asyncio.coroutinefixtures. From inside the code, such fixtures appears as common generators - didnt realized how to distinguish them from, for example, user-defined fixtures that supposed to return generators.functionscope is supported. I'll try to solve it. The main problem that async fixtures must (or not?) be run in the same event loop as test function. Withmoduleandsessionscoped fixtures this could be a problem.Closes #41