Skip to content

feat: add a way to unbind plugins#612

Closed
Miou-zora wants to merge 8 commits into
mainfrom
450-feature-enable-dynamic-runtime-loading-of-plugin-files
Closed

feat: add a way to unbind plugins#612
Miou-zora wants to merge 8 commits into
mainfrom
450-feature-enable-dynamic-runtime-loading-of-plugin-files

Conversation

@Miou-zora

@Miou-zora Miou-zora commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Related Issues (Optional, put "None" if there are no related issues)

Fixes #(issue)
Relates to #(issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Build/CI configuration change
  • Project related stuff

Changes Made

List of the main changes in this PR:

  • Change 1
  • Change 2
  • Change 3

Testing (Optional, put "None" if you didn't have to test anything)

  • Unit tests pass (xmake test)
  • Code follows the project's style guidelines (clang-format)
  • Manual testing performed (describe what you tested)

Test Environment

  • OS: [e.g. Windows, Ubuntu, macOS]
  • Compiler: [e.g. MSVC, GCC, Clang]

Documentation

  • I have updated the relevant documentation
  • I have added/updated comments in the code
  • No documentation changes are required

Checklist (Don't delete any options)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Time Spent (Optional, put "None" if you don't know)

Screenshots/Videos (Optional, put "None" if it's not relevant)

Breaking Changes (Optional, Put "None" if there are no breaking changes)

Additional Notes (Optional, Put "None" if there are no additional notes)

@Miou-zora Miou-zora linked an issue Jun 2, 2026 that may be closed by this pull request
[FEATURE] Enable dynamic (runtime) loading of plugin files #450
Open
@coderabbitai

coderabbitai Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 58c3def8-7d50-41f2-9278-c090e1541594

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 450-feature-enable-dynamic-runtime-loading-of-plugin-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Jun 3, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Miou-zora

Miou-zora commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

By doing this issue now and with this way of implementation, it adds too much complexity internally (too much side effects) and externally (the way systems are registered and executed is not explicit at all so is error prone). And adding this will ask the users to add default complexity to their projects.

So I decided to close this PR and branch until a new way is found to avoid too much complexity and side effects.

Here is some data found while searching and exploring ways to implement this: https://drive.google.com/file/d/1-DHvbn5n6PfJMO75ExwOjWoTVE6P9kTi/view?usp=sharing

Feel free to share your ideas and suggest a way of implementation.

@Miou-zora Miou-zora closed this Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable dynamic (runtime) loading of plugin files

1 participant

@Miou-zora