Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: htmlhint/HTMLHint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: New-Future/HTMLHint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 72 files changed
  • 6 contributors

Commits on Feb 23, 2019

  1. fix: missing test cases (#327)

    **Fixes**: #325 
    
    - [x] Check the commit's or even all commits' message styles matches our requested structure.
    - [x] Check your code additions will fail neither code linting checks nor unit test.
    
    #### Short description of what this resolves:
    In the original pull request some of the test cases were missing. Added --recursive option for mocha to check for all individual rules.
    PixelDust22 authored and thedaviddias committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    a344882 View commit details
    Browse the repository at this point in the history
  2. feat(htmlhint): add new rule for whitespace in attributes (#310) (#322)

    * 0.10.3
    
    * feat(htmlhint): add new rule for whitespace in attributes (#310)
    
    * fix(htmlhint): removed unnecessary code (#310)
    
    * 0.11.0
    
    * Revert "Merge branch 'develop' into attr-whitespace"
    
    This reverts commit 35988c1, reversing
    changes made to 981cca7.
    
    * Revert "Revert "Merge branch 'develop' into attr-whitespace""
    
    This reverts commit cfa794d.
    
    * chore(htmlhint): rebuilt package.json
    
    * chore(htmlhint): updated rule to use ES6
    
    * 0.10.3
    
    * 0.11.0
    
    * fix(htmlhint): made change to test cases and index.js
    Daman Mulye authored and thedaviddias committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    422c968 View commit details
    Browse the repository at this point in the history
  3. html.js (#304)

    This is a new formatter which logs error messages in html format on console as well as it will generate a report file in html format
    
    **Fixes**: #
    
    🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨
    **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:**
    
    - [x] Check the commit's or even all commits' message styles matches our requested structure.
    - [x] Check your code additions will fail neither code linting checks nor unit test.
    
    #### Short description of what this resolves:
    New formatter
    
    #### Proposed changes:
    New formatter
    
    ## -
    
    -
    
    👍 Thank you!
    nmanupuri authored and thedaviddias committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    d343265 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2019

  1. fix(htmlhint): added rule for special characters in tag name (#146) (#…

    …331)
    
    **Fixes**: #
    
    🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨
    **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:**
    
    - [x] Check the commit's or even all commits' message styles matches our requested structure.
    - [x] Check your code additions will fail neither code linting checks nor unit test.
    
    #### Short description of what this resolves:
    Added rule to check for special characters in tag name. See (#146)
    #### Proposed changes:
    
    ## -
    
    -
    
    👍 Thank you!
    Daman Mulye authored and thedaviddias committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    e08043a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bdf28a8 View commit details
    Browse the repository at this point in the history
  3. fix(htmlhint): add ability to pass regexp in config (#328)

    Based on #238
    
    Add ability to pass regexp in `.htmlhintrc` file for matching attributes value.
    
    Example:
    ```js
    ...
    "id-class-value": {
        "regId": "^[a-z\\d]+([-_]+[a-z\\d]+)*$",
        "message": "The id and class attribute values must be in lowercase and split by dash or underscore"
    },
    ...
    ```
    
    Problem was in parsing config file by `JSON.parse`. We can not correct pass `regexp` into json schema. Only `string`. And this `string` after parsing is `string` too.
    
    I just check input data. If it is not regexp then create `new RegExp` instance from input string.
    
    **Fixes**: #
    
    🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨
    **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:**
    
    - [ ] Check the commit's or even all commits' message styles matches our requested structure.
    - [ ] Check your code additions will fail neither code linting checks nor unit test.
    
    #### Short description of what this resolves:
    
    #### Proposed changes:
    
    ## -
    
    -
    
    👍 Thank you!
    thedaviddias authored Feb 24, 2019
    Configuration menu
    Copy the full SHA
    a67b09d View commit details
    Browse the repository at this point in the history
  4. feat(htmlhint): added attribute sorting (#309) (#332)

    **Fixes**: #
    
    🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨
    **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:**
    
    - [ ] Check the commit's or even all commits' message styles matches our requested structure.
    - [ ] Check your code additions will fail neither code linting checks nor unit test.
    
    #### Short description of what this resolves:
    Added sort feature for tag attributes.
    #### Proposed changes:
    -
    ## -
    
    -
    
    👍 Thank you!
    orangewit3 authored and thedaviddias committed Feb 24, 2019
    Configuration menu
    Copy the full SHA
    bb9a51e View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. Used Object.keys instead of Object.values (#344)

    Used Object.keys instead of Object.values because it is not supported by nodejs before v8.
    meetDeveloper authored and thedaviddias committed May 20, 2019
    Configuration menu
    Copy the full SHA
    bd99276 View commit details
    Browse the repository at this point in the history
Loading