-
-
Notifications
You must be signed in to change notification settings - Fork 450
Comparing changes
Open a pull request
base repository: htmlhint/HTMLHint
base: main
head repository: New-Future/HTMLHint
compare: develop
- 8 commits
- 72 files changed
- 6 contributors
Commits on Feb 23, 2019
-
fix: missing test cases (#327)
**Fixes**: #325 - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: In the original pull request some of the test cases were missing. Added --recursive option for mocha to check for all individual rules.
Configuration menu - View commit details
-
Copy full SHA for a344882 - Browse repository at this point
Copy the full SHA a344882View commit details -
feat(htmlhint): add new rule for whitespace in attributes (#310) (#322)
* 0.10.3 * feat(htmlhint): add new rule for whitespace in attributes (#310) * fix(htmlhint): removed unnecessary code (#310) * 0.11.0 * Revert "Merge branch 'develop' into attr-whitespace" This reverts commit 35988c1, reversing changes made to 981cca7. * Revert "Revert "Merge branch 'develop' into attr-whitespace"" This reverts commit cfa794d. * chore(htmlhint): rebuilt package.json * chore(htmlhint): updated rule to use ES6 * 0.10.3 * 0.11.0 * fix(htmlhint): made change to test cases and index.js
Configuration menu - View commit details
-
Copy full SHA for 422c968 - Browse repository at this point
Copy the full SHA 422c968View commit details -
This is a new formatter which logs error messages in html format on console as well as it will generate a report file in html format **Fixes**: # 🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨 **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:** - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: New formatter #### Proposed changes: New formatter ## - - 👍 Thank you!
Configuration menu - View commit details
-
Copy full SHA for d343265 - Browse repository at this point
Copy the full SHA d343265View commit details
Commits on Feb 24, 2019
-
fix(htmlhint): added rule for special characters in tag name (#146) (#…
…331) **Fixes**: # 🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨 **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:** - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: Added rule to check for special characters in tag name. See (#146) #### Proposed changes: ## - - 👍 Thank you!
Configuration menu - View commit details
-
Copy full SHA for e08043a - Browse repository at this point
Copy the full SHA e08043aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdf28a8 - Browse repository at this point
Copy the full SHA bdf28a8View commit details -
fix(htmlhint): add ability to pass regexp in config (#328)
Based on #238 Add ability to pass regexp in `.htmlhintrc` file for matching attributes value. Example: ```js ... "id-class-value": { "regId": "^[a-z\\d]+([-_]+[a-z\\d]+)*$", "message": "The id and class attribute values must be in lowercase and split by dash or underscore" }, ... ``` Problem was in parsing config file by `JSON.parse`. We can not correct pass `regexp` into json schema. Only `string`. And this `string` after parsing is `string` too. I just check input data. If it is not regexp then create `new RegExp` instance from input string. **Fixes**: # 🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨 **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:** - [ ] Check the commit's or even all commits' message styles matches our requested structure. - [ ] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: #### Proposed changes: ## - - 👍 Thank you!
Configuration menu - View commit details
-
Copy full SHA for a67b09d - Browse repository at this point
Copy the full SHA a67b09dView commit details -
feat(htmlhint): added attribute sorting (#309) (#332)
**Fixes**: # 🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨 **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:** - [ ] Check the commit's or even all commits' message styles matches our requested structure. - [ ] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: Added sort feature for tag attributes. #### Proposed changes: - ## - - 👍 Thank you!
Configuration menu - View commit details
-
Copy full SHA for bb9a51e - Browse repository at this point
Copy the full SHA bb9a51eView commit details
Commits on May 20, 2019
-
Used Object.keys instead of Object.values (#344)
Used Object.keys instead of Object.values because it is not supported by nodejs before v8.
Configuration menu - View commit details
-
Copy full SHA for bd99276 - Browse repository at this point
Copy the full SHA bd99276View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...develop