[None][test] Waive 7 failed cases for main in QA CI#14498
Conversation
xinhe-nv
requested review from
LarryXFly,
StanleySun639,
crazydemo and
jieli-matrix
jieli-matrix
force-pushed
the
trtllm-ci-report/waive-20260523-224825
branch
from
7e178f6 to
ad60a23
Compare
|
I found there are some dups with #14515 |
📝 WalkthroughWalkthroughThis PR updates the test waivers list by adding five SKIP entries for unstable or failing tests across different model implementations. The changes span three test files and three model test classes, marking specific test cases to be skipped during CI execution. ChangesTest Waivers Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
9-108: QA list updates are unnecessary for this PR scope.This change is waive-only in
tests/integration/test_lists/waives.txtand does not add or alter integration test definitions, so notests/integration/test_lists/qa/*updates are needed in this PR.As per coding guidelines: “If the PR only touches unittest/ or narrow unit scope, say explicitly whether QA list updates are unnecessary or optional.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 9 - 108, The change only updates tests/integration/test_lists/waives.txt (a waive-only change) and therefore does not require any updates to the QA lists under tests/integration/test_lists/qa; please update the PR description or commit message to explicitly state “QA list updates are unnecessary for this PR” and ensure no files under tests/integration/test_lists/qa/* are modified in this commit, leaving tests/integration/test_lists/waives.txt as the only test-list change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 9: The waive list contains an entry referencing
TestNemotron3Super120B::test_nixl_backend but that class has no
test_nixl_backend; open the test_disaggregated_serving.py file, find the actual
test method(s) defined under class TestNemotron3Super120B (and any
parametrizations), then update the waive entry in waives.txt to the correct
canonical nodeid(s) (e.g.
<test_file>::TestNemotron3Super120B::actual_test_name[params] style) or remove
the stale line if there is no matching test; ensure the nodeid exactly matches
the test class/method and includes parameter suffixes if present.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 9-108: The change only updates
tests/integration/test_lists/waives.txt (a waive-only change) and therefore does
not require any updates to the QA lists under tests/integration/test_lists/qa;
please update the PR description or commit message to explicitly state “QA list
updates are unnecessary for this PR” and ensure no files under
tests/integration/test_lists/qa/* are modified in this commit, leaving
tests/integration/test_lists/waives.txt as the only test-list change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 971ce55f-ac37-4914-ac18-472af298d839
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
jieli-matrix
force-pushed
the
trtllm-ci-report/waive-20260523-224825
branch
from
bf9f461 to
fb21268
Compare
Bug(s): 6162618, 6206179, 6211185, 6211189, 6211436, 6211441 Requested by: [email protected] Jenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_CLUSTER_TEST/1458/ Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Jie Li <[email protected]>
jieli-matrix
force-pushed
the
trtllm-ci-report/waive-20260523-224825
branch
from
fb21268 to
3f757c5
Compare
|
/bot run --stage-list "" |
|
PR_Github #50510 [ run ] triggered by Bot. Commit: |
Signed-off-by: Jie Li <[email protected]>
|
/bot run --stage-list "" |
|
PR_Github #50516 [ run ] triggered by Bot. Commit: |
|
PR_Github #50510 [ run ] completed with state |
|
PR_Github #50516 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #50541 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #50541 [ reuse-pipeline ] completed with state |
Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Jie Li <[email protected]> Co-authored-by: Jie Li <[email protected]>
3 participants
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by [email protected])
Target branch:
mainJenkins build: https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_CLUSTER_TEST/1458/
Bug(s): 6162618, 6206179, 6211185, 6211189, 6211436, 6211441
Waive entries added
Already waived (skipped)
accuracy/test_llm_api_pytorch_multimodal.py::TestGemma3_27BInstruct::test_fp8_prequantizedaccuracy/test_llm_api_pytorch.py::TestQwen3_5_35B_A3B::test_bf16_mtp[mtp_on]This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit