Skip to content

feat(core): TextBase Span interaction and styling improvements#10682

Merged
NathanWalker merged 4 commits into
NativeScript:mainfrom
CatchABus:fix/link-tap-emit
Jan 31, 2025
Merged

feat(core): TextBase Span interaction and styling improvements#10682
NathanWalker merged 4 commits into
NativeScript:mainfrom
CatchABus:fix/link-tap-emit

Conversation

@CatchABus

@CatchABus CatchABus commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

What is the new behavior?

This PR enhances some points around TextBase Span interaction and view disposal.
More specifically:

  • Added linkTap event support for other iOS views that nest spans
  • Prevent android span from setting parent background color to itself since it doesn't react to changes of that property. Unless background color is specified to the span directly, it's going to be transparent
  • Added few missing nativeTextViewProtected references
  • Improved view disposal for classes that inherit from TextBase as they had leftovers after android activity recreation
  • Removed 2 assignments of userInteractionEnabled from TextBase as they were unneeded and had conflicts with isUserInteractionEnabled property. Core already sets that property to true for the views that need it in createNativeView call
  • HTMLView will remove extra padding using the documented UIEdgeInsetsZero

@NathanWalker NathanWalker added this to the 8.9 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants