fix(core): Corrected background color between Label and nested spans#10701
Merged
Conversation
CatchABus
changed the title
CatchABus
changed the title
CatchABus
force-pushed
the
fix/ios-span-color
branch
from
4b15075 to
b12c28d
Compare
Collaborator
|
@CatchABus you are a machine! what s your model number ? T5000 ? |
NathanWalker
approved these changes
Feb 20, 2025
Contributor
|
I would like to second that notion, I think @CatchABus got the bionic chip implanted 👀 |
This was referenced Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There are cases when TextBase and Span background colors mismatch.
That is very apparent when tapping a button with spans and css
:pressedpseudo-state.What is the new behavior?
Spans will be colorless (transparent) to display TextBase parent background color unless they or their
FormattedStringparents have a background color of their own.This issue was partially fixed on android but also broke
FormattedStringcolor inheritance, so this PR fixes that too (see #10682).Fixes/Closes #7379 .