fix: add CMCONF_FLEET_PROTOCOL_DIR to cmake builds#51
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a shared Docker build stage Changes
Sequence Diagram(s)sequenceDiagram
participant Docker as Docker build
participant CMCONF as CMCONF server
participant Module as Module builder (CMake)
Docker->>CMCONF: download CMCONF_FLEET_PROTOCOLConfig.cmake
CMCONF-->>Docker: return config file
Docker->>Module: inherit cpp_build_base (has /home/bringauto/cmconf)
Module->>Module: run CMake with -DCMCONF_FLEET_PROTOCOL_DIR=/home/bringauto/cmconf (packages-only)
Module->>Module: run CMake with -DCMCONF_FLEET_PROTOCOL_DIR=/home/bringauto/cmconf (install)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile`:
- Around line 5-7: The Dockerfile currently downloads
CMCONF_FLEET_PROTOCOLConfig.cmake from the floating master branch; add a build
ARG (e.g., CMCONF_REF or CMCONF_VERSION) and use it in the wget URL to pin the
fetch to a specific commit/tag. Specifically, introduce ARG CMCONF_VERSION (with
a sensible default or empty), then update the RUN wget target URL for
CMCONF_FLEET_PROTOCOLConfig.cmake to replace "master" with ${CMCONF_VERSION} so
builds can be reproduced and overridden at build time; ensure the created
directory and filename (CMCONF_FLEET_PROTOCOLConfig.cmake) remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Docker build failure caused by CMCONF v1.2.x requiring explicit config path via
-DCMCONF_FLEET_PROTOCOL_DIR.Summary by CodeRabbit