Fix #8239: mitmweb WebSocket crash on invalid filter expression#8250
Open
ErnestHysa wants to merge 2 commits into
Open
Fix #8239: mitmweb WebSocket crash on invalid filter expression#8250ErnestHysa wants to merge 2 commits into
ErnestHysa wants to merge 2 commits into
Conversation
Wrap filter parsing in try/except to catch ValueError from invalid filter expressions (e.g., unmatched quotes) and return an error message to the client instead of crashing the WebSocket connection. The error is returned as a flows/filterError message with the filter name and error description, allowing the client to display feedback without losing the connection.
Member
|
Thanks for the PR, I would just put it in stand by because I would like to clarify first something related to filters that I mentioned in #8245 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #8239: mitmweb disconnects on unmatched quote in filter.
When mitmweb receives an invalid filter expression (e.g., with unmatched quotes), the WebSocket connection would crash because flowfilter.parse() raises a ValueError that was not being caught in update_filter().