python: add comprehensive checkpoint test#6185
Merged
Merged
Conversation
gz
force-pushed
the
checkpoint-test
branch
2 times, most recently
from
bb68480 to
b69c718
Compare
mythical-fred
left a comment
mythical-fred
left a comment
There was a problem hiding this comment.
Nice piece of work. Test is well-structured: deterministic data gen, completion-token waits (no sleeps), order-independent hash asserts, explicit cache-key rotation guidance. A few questions/concerns inline — none blocking.
abhizer
approved these changes
May 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
We didn't have reasonable coverage for checkpoints making sure that we don't break it in a backward incompatible way. This test attempts to fix that. Signed-off-by: Gerd Zellweger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't have reasonable coverage for checkpoints making sure that we don't break it in a backward incompatible way.
This test attempts to fix that.
Describe Manual Test Plan
I ran the test
Checklist
Breaking Changes?
No