Bye bye database xml#21641
Merged
Merged
Conversation
nickvergessen
added
3. to review
ChristophWurst
approved these changes
Jun 30, 2020
nickvergessen
force-pushed
the
techdebt/noid/bye-bye-database-xml
branch
from
6be4bc3 to
569975e
Compare
nickvergessen
commented
Jul 1, 2020
nickvergessen
added
2. developing
This was referenced Jul 6, 2020
nickvergessen
force-pushed
the
techdebt/noid/bye-bye-database-xml
branch
from
87c6d9e to
2316080
Compare
Member
|
Something for 21 |
Member
Author
|
Should merge/redo after 21 is branched off. |
ChristophWurst
added
the
pending documentation
Member
|
a wild group of conflicts appeared |
Member
Author
|
yeah, anyone can feel free to take over and re do it. |
Member
|
The first two commits are already handled by #24247. Let me continue there. |
Member
MorrisJobke
force-pushed
the
techdebt/noid/bye-bye-database-xml
branch
from
2316080 to
4851efd
Compare
MorrisJobke
added
3. to review
Signed-off-by: Joas Schilling <[email protected]>
MorrisJobke
force-pushed
the
techdebt/noid/bye-bye-database-xml
branch
from
4851efd to
bb0c507
Compare
Member
|
I just cleaned up a bit behind the removal of the usage of database.xml and removed all the helper classes (and their tests). 🧹 |
MorrisJobke
force-pushed
the
techdebt/noid/bye-bye-database-xml
branch
from
25316f1 to
6b9a765
Compare
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
techdebt/noid/bye-bye-database-xml
branch
from
6b9a765 to
ab48d5e
Compare
MorrisJobke
approved these changes
Mar 24, 2021
MorrisJobke
left a comment
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Looks good from my side 🚀
ChristophWurst
removed
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.