Claude review of PR #42488 (b08d5a4)

The reordering logic is correct and memory-safe — node ownership stays well-defined, the list head stays consistent, the insertion sorts terminate, and no downstream consumer (partno/offset assignment, supplement resolution, place/grow, JSON dump) depends on the old ordering. The new integration test is auto-discovered, deterministic across architectures, self-consistent, and would fail without the code change. A few maintainability/clarity notes only:

Suggestions

• Sentinel offsets in existing bucket — src/repart/repart.c:11292 — dropped/suppressed/new-unallocated partitions still have offset == UINT64_MAX and sort to the tail; restrict the offset sort to real on-disk partitions or document the sentinel behavior.
• Extract reorder into a helper — src/repart/repart.c:11310 — the ~40-line anonymous { ... } block would read better as a named context_*() helper, matching the file's idiom.
• Use LIST_POP for the first loop — src/repart/repart.c:11250 — the bucket-split loop could use the while ((p = LIST_POP(...))) idiom of the other three loops instead of LIST_FOREACH_WITH_NEXT plus a manual LIST_REMOVE.
• Use unsigned/size_t for partition counters — src/repart/repart.c:4326 — n_partitions/cur_n_partition are declared unsigned int; prefer size_t for both the CODING_STYLE unsigned-form rule and consistency with the file's other partition counters.

Nits

• Hoist duplicated LIST_REMOVE — src/repart/repart.c:11279 — the LIST_REMOVE call is identical in both if/else branches and can be moved before the conditional.
• Missing assert(context) — src/repart/repart.c:11246 — context_sort_partitions() omits the leading assert(context); used by the other context_*() helpers in this file.
• Dropped partitions break dump underline — src/repart/repart.c:11292 — appending all dropped partitions to the tail suppresses the size/padding sum underline on the last rendered row in context_dump_partitions() whenever anything is dropped (terminal table only).
• Redundant sfdisk assertions in test — test/units/TEST-58-REPART.sh:849 — the trailing sfdisk --dump assert_in block largely duplicates the JSON diff, and its truncated patterns don't validate uuid/name.

Workflow run

Workflow run