Skip to content

feat: add GET: dataset.statistics#324

Merged
vdusek merged 1 commit into
masterfrom
feat/dataset-statistics-endpoint
Jan 7, 2025
Merged

feat: add GET: dataset.statistics#324
vdusek merged 1 commit into
masterfrom
feat/dataset-statistics-endpoint

Conversation

@mfori

@mfori mfori commented Jan 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Part of https://github.com/apify/apify-core/issues/18807 - Implementation of new API endpoint v2/datasets/{datasetId}/statistics

@mfori mfori added the t-console Issues with this label are in the ownership of the console team. label Jan 1, 2025
@mfori mfori self-assigned this Jan 1, 2025
@mfori mfori requested a review from vdusek January 6, 2025 15:37
@mfori mfori marked this pull request as ready for review January 6, 2025 15:37
@vdusek vdusek requested a review from Pijukatel January 6, 2025 15:47
Pijukatel
Pijukatel reviewed Jan 7, 2025
View reviewed changes

@Pijukatel Pijukatel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to add some basic test for this.

@mfori

mfori commented Jan 7, 2025

Copy link
Copy Markdown
Member Author

I would suggest to add some basic test for this.

@Pijukatel Sorry I don't write python often, but in js-client we have ready set of tests, for testing that just the right API endpoint is called, but I don't see any similar setup in this repo. The actual endpoint integration tests are in apify-core so I don't think it's necessary to test functioning of API endpoint again here.

@vdusek

vdusek commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

@Pijukatel Sorry I don't write python often, but in js-client we have ready set of tests, for testing that just the right API endpoint is called, but I don't see any similar setup in this repo. The actual endpoint integration tests are in apify-core so I don't think it's necessary to test functioning of API endpoint again here.

We currently do not have any testing framework here, so we will have to leave it at that for now.

vdusek
vdusek approved these changes Jan 7, 2025
View reviewed changes

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@vdusek vdusek merged commit 19ea4ad into master Jan 7, 2025
@vdusek vdusek deleted the feat/dataset-statistics-endpoint branch January 7, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Pijukatel approved these changes

Assignees

@mfori mfori

Labels

t-console Issues with this label are in the ownership of the console team.

Projects

None yet

Milestone

105th sprint - Console team - Christmas

Development

Successfully merging this pull request may close these issues.

3 participants

@mfori @vdusek @Pijukatel