docs: misc academy docs fixes#2536
Conversation
|
🗑️ Preview for this PR was deleted. |
f5db17d to
d81e7d6
Compare
|
Thanks for working on this! omg, the Christmas tree 🤦♂️ I remember I browsed IKEA products for a while to find a category which won't have any four digit prices, so that the exercise is simple. And they add a Christmas tree to artificial plants 🔥 👿 🔥 |
|
the amazon frontend seems to have changed it seems, it's not possible to get more than one price for the products with crawlee since they are dynamically loaded. I don't think it's worth refactoring over, I've just added a note to https://docs.apify.com/academy/expert-scraping-with-apify/actors-webhooks |
|
I'm done with the onboarding, I fixed most things I was able to find, no perfect solutions for anything but still in the spirit of "if it's better than current, ship it" 😄 |
szaganek
left a comment
There was a problem hiding this comment.
Thanks for the detailed update! I left some comments.
A note for the future, please make sure to check our contributing guidelines for tips on styling (like admonitions). You can also run docs-review Claude skill locally to catch some problems before opening a PR.
|
Wow, thanks for the detailed review! Happy to see such strict attitude around the docs, as it should be ;) and you're right I should've read through contributing.md more carefully before the commits :) will go through the comments in a bit. |
|
forgot the |
366f748 to
8cde792
Compare
|
There were a lot of small change commits so I merged them together and pushed with How do things look now? edit: the preview build failed once despite the checks passing for some reason, I pushed an empty commit, preview built succesfully, then removed the empty commit to keep the history clean. |
bff32fe to
d527f83
Compare
Hi folks, I'm going through some of the academy docs, I'll try to fix any inconsistencies I find here