Merge tag 'v3.2.8' into 'main'#319
Merged
Merged
Conversation
dougbu
commented
Apr 15, 2022
dougbu
commented
Contributor
- see https://github.com/aspnet/AspNetWebStack/releases/tag/v3.2.8 for prominent issues resolved as well as a more detailed list of changes
- reformat README.md - merge 'Git tag' and 'Git branch' columns - remove old v3.2.4 / v5.2.4 information - add v3.2.7 / v5.2.7 information
- test using netcoreapp2.1 - react to .NET Core breaking change - see https://docs.microsoft.com/en-us/dotnet/core/compatibility/2.1#path-apis-dont-throw-an-exception-for-invalid-characters - suppress NU5125 warnings - break the build because warnings are treated as errors - do not validate Expires header values - #263
Constrain the MemoryStream size
#312) * Configure max request line size limits to be the same as maxHeaderSize As part of ReadAsHttpRequestMessageAsync, the parsing of the HTTP request line is limited by a non-configurable 2k limit. The size does not affect buffer sizes, only the maximum allowed length. This PR updates the ReadAsHttpRequestMessageAsync API to use the same limits for HTTP request line as the HTTP header line, the latter which is configurable by user code. In the default case, this means the HTTP request line size now supports a 16k limit before it throws. Fixes #307
- remove `<requireLicenseAcceptance/>` as well - can't require a license w/o `<license/>` or `<licenseUrl/>` - also, don't need to ignore NU5125 anymore
- brings in recent fixes from last release
dougbu
commented
Apr 15, 2022
Comment on lines
+323
to
+326
| if (string.Equals("expires", name, StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| ignoreHeaderValidation = true; | ||
| } |
Contributor
Author
| HttpUnsortedRequest httpRequest = new HttpUnsortedRequest(); | ||
| HttpRequestHeaderParser parser = new HttpRequestHeaderParser(httpRequest, | ||
| HttpRequestHeaderParser.DefaultMaxRequestLineSize, maxHeaderSize); | ||
| Math.Max(HttpRequestHeaderParser.DefaultMaxRequestLineSize, maxHeaderSize), maxHeaderSize); |
| /// has become available allowing the action to write to it directly. When the | ||
| /// stream is closed, it will signal to the content that is has completed and the | ||
| /// has become available allowing the action to write to it directly. When the | ||
| /// stream is closed, it will signal to the content that it has completed and the |
Contributor
Author
There was a problem hiding this comment.
Doc comment updates in this class are to fix #310
Comment on lines
-11
to
-12
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | ||
| <licenseUrl>http://www.microsoft.com/web/webpi/eula/mvc4extensions_prerelease_eula.htm</licenseUrl> |
Contributor
Author
There was a problem hiding this comment.
The two changes like this are part of our fix for #314. The rest is in internal build infrastructure. Yes, we are working toward including YAML in this repo for the builds.
| if (Type.GetType(_netCore20TypeName, throwOnError: false) != null) | ||
| { | ||
| // Treat .NET Core 2.0 as a .NET 4.5 superset though internal types are different. | ||
| // Treat .NET Core 2.1 as a .NET 4.5 superset though internal types are different. |
Contributor
Author
There was a problem hiding this comment.
.NET Core 2.0 is out of support. 2.1 is also mostly out of support but ASP.NET Core 2.1.x is still getting updates for many packages (those that work on full "desktop" .NET Framework).
TanayParikh
approved these changes
Apr 15, 2022
dougbu
added a commit
that referenced
this pull request
Apr 15, 2022
- redo merge to restore the complete history - no files changed because I accidentally squashed the commits in #319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.