src/plugin/physics/tests/CharacterControllerTest.cpp (1)

41-46: Make shutdown unconditional even on fatal assertions.

Because ASSERT_TRUE at Line 41 can return early, Line 46 may be skipped. Wrap shutdown in a local guard so cleanup always runs.

♻️ Proposed refactor

 TEST(CharacterControllerPlugin, CharacterControllerCreation)
 {
     Engine::Core core;
+    struct ShutdownGuard {
+        Engine::Core &core;
+        ~ShutdownGuard() { core.GetScheduler<Engine::Scheduler::Shutdown>().RunSystems(); }
+    } shutdownGuard{core};
 
     core.SetErrorPolicyForAllSchedulers(Engine::Scheduler::SchedulerErrorPolicy::Nothing);
@@
     const auto &internal = player.GetComponents<Physics::Component::CharacterControllerInternal>();
     EXPECT_TRUE(internal.IsValid());
-
-    core.GetScheduler<Engine::Scheduler::Shutdown>().RunSystems();
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/plugin/physics/tests/CharacterControllerTest.cpp` around lines 41 - 46,
The test currently calls
ASSERT_TRUE(player.HasComponents<Physics::Component::CharacterControllerInternal>())
which may abort the test early and skip cleanup; wrap the shutdown call
core.GetScheduler<Engine::Scheduler::Shutdown>().RunSystems() in a local RAII
guard so it always runs (e.g., define a small local struct or use a scope-exit
helper whose destructor calls
core.GetScheduler<Engine::Scheduler::Shutdown>().RunSystems()), construct that
guard before the ASSERT_TRUE, then leave the rest of the test using
player.GetComponents<Physics::Component::CharacterControllerInternal>() as-is so
cleanup always executes even on fatal assertions.