test: dont assert websocket closes without error#25573
Merged
spikecurtis merged 1 commit intoMay 21, 2026
Merged
Conversation
ibetitsmike
approved these changes
May 21, 2026
spikecurtis
force-pushed
the
spike/internal-1541-disable-flaky-no-error-closing-websocket
branch
from
934cff5 to
80963fd
Compare
Contributor
Author
Merge activity
|
spikecurtis
deleted the
spike/internal-1541-disable-flaky-no-error-closing-websocket
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes coder/internal#1541
Closing websockets can race whether they return an error or not if the remote side closes too. Dropping some test assertions about this since it is not critical to what we are testing.