Fix #12083 FN passedByValue with usage in ternary#5575
Merged
chrchr-github merged 13 commits intoOct 31, 2023
Conversation
firewave
reviewed
Oct 19, 2023
chrchr-github
commented
Oct 19, 2023
| } | ||
|
|
||
| // TODO cppcheck-suppress passedByValue | ||
| // cppcheck-suppress passedByValue |
Collaborator
Author
There was a problem hiding this comment.
This seems to be a shortcoming of canBeConst().
chrchr-github
commented
Oct 19, 2023
| " static int& i = x[0];\n" | ||
| " return i;\n" | ||
| "}"); | ||
| ASSERT_EQUALS("", errout.str()); |
Collaborator
Author
There was a problem hiding this comment.
Here we show a warning although i also needs to be changed. Acceptable?
Collaborator
There was a problem hiding this comment.
No sure.
But it looks like code which applies to the suggested https://trac.cppcheck.net/ticket/11565.
Collaborator
Author
There was a problem hiding this comment.
We actually detect the a danglingReference in the test case.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.