fix non-fetchable hashes in openssl dgst -list#20651
Closed
GauriSpears wants to merge 2 commits into
Closed
Conversation
openssl-machine
added
the
hold: cla required
CLA: trivial
openssl-machine
removed
the
hold: cla required
Contributor
Author
|
Hi! Should I do anything else to start approval process? |
paulidale
approved these changes
Apr 12, 2023
paulidale
added
branch: master
t8m
added
tests: exempted
Member
|
This is borderline on CLA: trivial - @paulidale are you OK with CLA: trivial? |
github-actions
Bot
added
the
severity: fips change
Contributor
|
I'm okay with trivial. |
t8m
requested changes
Apr 12, 2023
Member
|
@paulidale please reconfirm |
Contributor
|
Confirmed. I don't feel that reconfirmation is necessary for a trivial reformatting like this. |
paulidale
added
approval: done
Contributor
Author
|
Thanks! Could you explain what's wrong with this CIFuzz / Fuzzing error? |
Member
That's issue #20712 |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Member
|
Squashed and merged to master, 3.1, and 3.0 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 14, 2023
CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #20651)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 14, 2023
CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #20651) (cherry picked from commit 7eab768)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 14, 2023
CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #20651) (cherry picked from commit 7eab768)
MrE-Fog
pushed a commit
to MrE-Fog/opensslz
that referenced
this pull request
Apr 15, 2023
CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl/openssl#20651)
kafei-cy
added a commit
to kafei-cy/Tongsuo
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openssl dgst -engine gost -listdoesn't show hashes added by gost-engine because they are not supported by EVP_MD_fetch and EVP_get_digestbyname should be used instead. Another example of this issue has been fixed in #12689By the way,
openssl enc -engine gost -listworks correctly.CLA: trivial