Conversation
Implemented support for the DISTINCT keyword in both Query and QueryBasic classes, allowing for distinct queries. Added corresponding tests to validate this functionality and ensure compatibility across both classes.
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Undefined 'distinct' Property ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| src/Query.php | ✅ |
| src/QueryBasic.php | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for the DISTINCT keyword in both
QueryandQueryBasicclasses, enabling distinct queries. Added tests to confirm correctness and ensure compatibility across the classes.Description by Korbit AI
What change is being made?
Add support for the DISTINCT keyword in the Query and QueryBasic classes, including corresponding unit tests.
Why are these changes being made?
This change enhances the querying capabilities by allowing the DISTINCT keyword, addressing the need to filter out duplicate results in query outputs. Implementing tests ensures the new feature works as intended and does not introduce regressions into the existing codebase.