docs: host documentation media in-repo (GraphCMS migration)#373
Conversation
Replace GraphCMS (Hygraph) media URLs in documentation with paths under assets/docs/, and add the corresponding image, GIF, JPG, MP4, and WebP files. Doc pages under docs/ now reference ../assets/docs/ for migrated media, alongside existing assets/docs/export-pdf and run-snapshots. Staged from internal migration work (PRO-90). One broken GraphCMS asset referenced by security-overview remains omitted; that page was adjusted during the original migration. Teach cspell to ignore ../assets/docs/... paths so opaque asset filenames do not produce false positives. Co-authored-by: Cursor <[email protected]>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (195)
⛔ Files ignored due to path filters (105)
⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (105)
📒 Files selected for processing (195)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 145 145
Lines 8018 8018
Branches 2227 2227
=======================================
Hits 6730 6730
Misses 1287 1287
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ported changes from deepnote-internal PR 20072.
dinohamzic
left a comment
There was a problem hiding this comment.
Do the scrips in deepnote-internal that copy docs from this repo during build need to be updated to included this new assets path?
|
@dinohamzic No. Since those images are now in github, we are pointing directly to github to serve the assets. |
Summary
This change moves documentation images and videos from Hygraph (GraphCMS) CDN URLs into the repository under
assets/docs/, and updatesdocs/*.mdto reference them via../assets/docs/.... Existing structured assets (assets/docs/export-pdf/,assets/docs/run-snapshots/) are unchanged.Context
Upstream migration was staged in deepnote/deepnote-internal#20072 (PRO-90). This PR applies that content to the public monorepo.
Notes
cspell.json: AddedignoreRegExpListfor../assets/docs/...paths so opaque filenames are not spell-checked as prose.security-overview.md: The hero image line tied to a deleted GraphCMS asset remains omitted (same as the migration PR).Verification
Pre-push hooks:
lintAndFormat,typecheck,test,spell-check.Made with Cursor