docs: host documentation media in-repo (GraphCMS migration)#373
Merged
Conversation
Replace GraphCMS (Hygraph) media URLs in documentation with paths under assets/docs/, and add the corresponding image, GIF, JPG, MP4, and WebP files. Doc pages under docs/ now reference ../assets/docs/ for migrated media, alongside existing assets/docs/export-pdf and run-snapshots. Staged from internal migration work (PRO-90). One broken GraphCMS asset referenced by security-overview remains omitted; that page was adjusted during the original migration. Teach cspell to ignore ../assets/docs/... paths so opaque asset filenames do not produce false positives. Co-authored-by: Cursor <[email protected]>
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (195)
⛔ Files ignored due to path filters (105)
⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (105)
📒 Files selected for processing (195)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 145 145
Lines 8018 8018
Branches 2227 2227
=======================================
Hits 6730 6730
Misses 1287 1287
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ported changes from deepnote-internal PR 20072.
dinohamzic
reviewed
May 11, 2026
dinohamzic
left a comment
dinohamzic
left a comment
Contributor
There was a problem hiding this comment.
Do the scrips in deepnote-internal that copy docs from this repo during build need to be updated to included this new assets path?
Contributor
Author
|
@dinohamzic No. Since those images are now in github, we are pointing directly to github to serve the assets. |
dinohamzic
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change moves documentation images and videos from Hygraph (GraphCMS) CDN URLs into the repository under
assets/docs/, and updatesdocs/*.mdto reference them via../assets/docs/.... Existing structured assets (assets/docs/export-pdf/,assets/docs/run-snapshots/) are unchanged.Context
Upstream migration was staged in deepnote/deepnote-internal#20072 (PRO-90). This PR applies that content to the public monorepo.
Notes
cspell.json: AddedignoreRegExpListfor../assets/docs/...paths so opaque filenames are not spell-checked as prose.security-overview.md: The hero image line tied to a deleted GraphCMS asset remains omitted (same as the migration PR).Verification
Pre-push hooks:
lintAndFormat,typecheck,test,spell-check.Made with Cursor