fix(security): bump hono override to >=4.12.21#393
Open
tkislan wants to merge 1 commit into
Open
Conversation
Resolve 4 moderate pnpm audit vulnerabilities in hono (transitive via packages/mcp > @modelcontextprotocol/sdk > hono), all fixed in 4.12.21: - GHSA-xrhx-7g5j-rcj5 (CVE-2026-47674, CVSS 5.3): ip-restriction middleware bypasses static deny rules for non-canonical IPv6. - GHSA-3hrh-pfw6-9m5x (CVE-2026-47675, CVSS 4.3): cookie helper does not sanitize sameSite and priority, allowing Set-Cookie injection. - GHSA-f577-qrjj-4474 (CVE-2026-47673, CVSS 4.8): jwt/jwk middleware accepts any Authorization scheme, not only Bearer. - GHSA-2gcr-mfcq-wcc3 (CVE-2026-47676, CVSS 5.3): app.mount() strips mount prefix using undecoded path, causing incorrect routing for percent-encoded paths. Bump the existing pnpm.overrides floor for hono >=4.12.18 -> >=4.12.21 following the established convention in this repo (see #387, #368, #307, #295, #292). pnpm install resolves hono to 4.12.23. After this change `pnpm audit` reports no known vulnerabilities. `pnpm typecheck`, `pnpm test` (2242 tests), and `pnpm prettier:check` all pass.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 145 145
Lines 8018 8018
Branches 2227 2165 -62
=======================================
Hits 6730 6730
Misses 1287 1287
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 4 moderate
pnpm auditvulnerabilities inhono(transitive viapackages/mcp > @modelcontextprotocol/sdk > hono), all fixed in 4.12.21.ip-restrictionmiddleware bypasses static deny rules for non-canonical IPv6cookiehelper does not sanitizesameSiteandpriority, allowing Set-Cookie injectionjwt/jwkmiddleware accepts any Authorization scheme, not onlyBearerapp.mount()strips mount prefix using undecoded path, causing incorrect routing for percent-encoded pathsChange
Bumps the existing
pnpm.overridesfloor in the rootpackage.jsonfromhono >=4.12.18tohono >=4.12.21, following the established convention in this repo (#387, #368, #307, #295, #292, …).pnpm installresolveshonoto 4.12.23.Verification
pnpm audit→ No known vulnerabilities foundpnpm typecheck→ passespnpm test→ 129 files, 2242/2242 tests passpnpm prettier:check→ all formattedpnpm biome:check→ exit 0 (the 2 reported warnings are pre-existing onmain, unrelated to this change)Summary by CodeRabbit